Use FetchContent module for msgpack #1040
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gikari
force-pushed
the
feature/fetch-content-msgpack
branch
from
dcdaa69 to
13e542e
Compare
Using fetch content cmake module is less verbose, than custom download and extract logic with setting of additional variables. CMake version 3.16 is in the Ubuntu 20.04 repository, so everyone should have at least it by now.
gikari
force-pushed
the
feature/fetch-content-msgpack
branch
from
13e542e to
b081ad6
Compare
Contributor
|
I think these changes will break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using fetch content cmake module is less verbose,
than custom download and extract logic with setting
of additional variables.
CMake version 3.16 is in the Ubuntu 20.04 repository,
so everyone should have at least it by now.
This should address the issue in #1036