Skip to content

Conversation

@ArkaSaha30
Copy link
Contributor

This PR will refactor AutoCert Provider struct to include userAutoConfig.

Fixes: #251

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArkaSaha30
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArkaSaha30 ArkaSaha30 force-pushed the refactor-user-autoconfig branch from 6d01458 to 9e6d59c Compare December 14, 2025 18:22
@ahrtr
Copy link
Member

ahrtr commented Dec 14, 2025

pls squash commits

@ArkaSaha30
Copy link
Contributor Author

/test pull-etcd-operator-test-e2e

@ArkaSaha30 ArkaSaha30 force-pushed the refactor-user-autoconfig branch from 332aa20 to 4878a77 Compare December 14, 2025 19:31
@ArkaSaha30 ArkaSaha30 force-pushed the refactor-user-autoconfig branch from 4878a77 to f22298c Compare December 15, 2025 05:11
@ArkaSaha30 ArkaSaha30 force-pushed the refactor-user-autoconfig branch 2 times, most recently from 7ed8770 to f5f484b Compare December 16, 2025 21:00
@ArkaSaha30 ArkaSaha30 force-pushed the refactor-user-autoconfig branch from f5f484b to 69f84fe Compare December 16, 2025 21:01
@k8s-ci-robot
Copy link

@ArkaSaha30: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-operator-test-e2e 69f84fe link true /test pull-etcd-operator-test-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor certificate management code bits

3 participants