Conversation
bcumming
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With spack/spack-packages#3106 a default value change for
gccvariantbinutilshas been introduced.This triggers a problem (see CI error) when building
binutils, which by default is builtlibs=static,sharedbut we explicitly preferzstd libs=static.stackinator/stackinator/templates/compilers.gcc.spack.yaml
Lines 22 to 23 in c7db13c
The proposed change does not fix the root problem, but it simply prefers building
gcc~builtinsas we've always did, completely workarounding the underlying problem.I'm going to address the root issue in spack, but for what concerns stackinator, at the moment IMHO this is the most reasonable and simple solution.