harden frame tx decoding from malformed responses - #878
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Both sides added process_transactions_test.go; the resolution keeps every test from each.
A blob or set-code transaction reported without the recipient its type requires decodes as an unknown type, like a frame transaction reported without its frames. Its missing recipient was no evidence of a creation, yet a CREATE address was derived from it and registered as a contract. A creation is now claimed only for a transaction decoded in full.
pk910
enabled auto-merge
October 2, 2026 11:04
![redpandabot[bot]](https://avatars.githubusercontent.com/in/3749543?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
The PR hardens tx indexing against clients that report a decodable transaction type without its type-specific content: the fetcher retries other clients and only falls back to the poorer answer, and processTransaction no longer reads a missing recipient of an undecoded transaction as a contract creation. The core fix is sound across the retry/fallback paths I traced, but the previously flagged sender-only debit for an undecoded value transfer remains unaddressed.
Issues
- 🟡
indexer/execution/txindexer/process_transactions.go:375— value transfer of an undecoded transaction is recorded as a sender-only debit — see the thread on that line
Reviewed @ 9debd719
"RTFM."
barnabasbusa
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.