fix(fetchers): surface malformed body errors#104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Treat malformed zero-byte response bodies as fetch errors instead of successful empty responses.
Closes #98.
Why
read_body_with_timeout()collapsed a body-stream failure before the first chunk into(empty, false). That let malformed chunked responses look like successful200 OKfetches with empty content, and the same path could also create misleading zero-byte files undersave_to_file.How
read_body_with_timeout()to returnFetchErrorwhen the body stream fails before any bytes are readtruncated=truellms.txtdocs-site pathsave_to_fileflowsRisk
Checklist
cargo fmt --allis passedcargo clippy --workspace --all-targets -- -D warningsis passedRUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-depsis passedcargo build --workspace --exclude fetchkit-python --releaseis passed