chore: require core v1.1.0#3391
Conversation
Bump the root module's core requirement from v1.0.0 to the freshly released core/v1.1.0, which carries the breaking Executor change (ExecuteTxs now returns ExecuteResult). The code has depended on this API since #3282 but go.mod still required v1.0.0, building only via the local `replace => ./core`. External consumers ignore that replace, so this must be v1.1.0 for a working release. Prerequisite for tagging v1.2.1 (v1.2.0 shipped with the stale v1.0.0 requirement and is superseded). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughUpdates the ChangesCore dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Remove `replace github.com/evstack/ev-node/core => ./core` so the published module resolves core v1.1.0 from the proxy with a proper go.sum checksum, instead of relying on a local path that consumers ignore. Local cross-module dev is handled by go.work (go.work.example already `use`s ./core). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3391 +/- ##
=======================================
Coverage 62.30% 62.30%
=======================================
Files 120 120
Lines 13454 13454
=======================================
+ Hits 8382 8383 +1
- Misses 4129 4130 +1
+ Partials 943 941 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Bumps the root module's core requirement
v1.0.0 → v1.1.0.Why
The root module has used
core.ExecuteResult/ the newExecutor.ExecuteTxssignature since #3282, butgo.modstill requiredcore v1.0.0(which has the old signature). It built only because of the localreplace github.com/evstack/ev-node/core => ./core. External consumers ignore replace directives, sogo get github.com/evstack/ev-node@<tag>resolved core v1.0.0 and failed to compile.core/v1.1.0is now published, sorequirecan point at it. The replace stays for in-repo dev.Context: supersedes v1.2.0
v1.2.0was tagged before core/v1.1.0 existed, so it froze the stalerequire core v1.0.0and is broken for consumers. It's already proxy-cached and therefore immutable, so we roll forward: this PR is the prerequisite for tagging v1.2.1.Verification
go build ./...passesgo mod tidyproduces no further diff (go.sum unchanged — local replace needs no checksum)🤖 Generated with Claude Code
Summary by CodeRabbit