Skip to content

Commit ba5b28b

Browse files
committed
PR feedback
1 parent 106cd3b commit ba5b28b

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

example/nextjs/app/error.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ export default function ErrorPage({ error, reset }) {
1414
await Exceptionless.createException(error)
1515
.addTags("error-boundary")
1616
.setProperty("handledBy", "app/error.jsx")
17-
.setProperty("digest", error.digest)
1817
.submit();
1918
} catch (submitError) {
2019
console.error("Exceptionless route boundary capture failed", submitError);

example/nextjs/app/global-error.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ export default function GlobalError({ error, reset }) {
1414
await Exceptionless.createException(error)
1515
.addTags("error-boundary")
1616
.setProperty("handledBy", "app/global-error.jsx")
17-
.setProperty("digest", error.digest)
1817
.submit();
1918
} catch (submitError) {
2019
console.error("Exceptionless global boundary capture failed", submitError);

example/nextjs/lib/exceptionless-server.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,14 @@ let startupPromise;
66

77
export async function startup() {
88
startupPromise ??= Exceptionless.startup((config) => {
9-
if (process.env.EXCEPTIONLESS_API_KEY ?? process.env.NEXT_PUBLIC_EXCEPTIONLESS_API_KEY) {
10-
config.apiKey = process.env.EXCEPTIONLESS_API_KEY ?? process.env.NEXT_PUBLIC_EXCEPTIONLESS_API_KEY;
9+
const apiKey = (process.env.EXCEPTIONLESS_API_KEY || process.env.NEXT_PUBLIC_EXCEPTIONLESS_API_KEY || "").trim();
10+
if (apiKey) {
11+
config.apiKey = apiKey;
1112
}
1213

13-
if (process.env.EXCEPTIONLESS_SERVER_URL ?? process.env.NEXT_PUBLIC_EXCEPTIONLESS_SERVER_URL) {
14-
config.serverUrl = process.env.EXCEPTIONLESS_SERVER_URL ?? process.env.NEXT_PUBLIC_EXCEPTIONLESS_SERVER_URL;
14+
const serverUrl = (process.env.EXCEPTIONLESS_SERVER_URL || process.env.NEXT_PUBLIC_EXCEPTIONLESS_SERVER_URL || "").trim();
15+
if (serverUrl) {
16+
config.serverUrl = serverUrl;
1517
}
1618

1719
if (process.env.NODE_ENV !== "production") {

0 commit comments

Comments
 (0)