DOC: Fix margin directive documentation#930
Merged
bsipocz merged 4 commits intoexecutablebooks:masterfrom Mar 6, 2026
Merged
Conversation
bsipocz
added
bug
Member
bsipocz
previously approved these changes
Mar 6, 2026
Member
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
Thank you @melissawm!
I have nitpick comments only that would make the rendered version look more consistent, but otherwise this now unblocks me to do the release!
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
Contributor
Author
|
Sorry didn't mean to dismiss your review! Is this a new github thing?? |
Member
Hmm, I'll look into the repo settings maybe something is weird there. |
Member
|
Yeap, it wasn't you but the settings; I unticked this box as I think it is more annoying than useful here. 
|
Member
|
Thank you again @melissawm for diving down into this rabbit hole! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #928
Addresses a recent change in Docutils 0.22+ which now flags as an error when a
docutils.parsers.rst.directives.body.Sidebarelement is nested under another element such as a topic or an admonition.See also sphinx-doc/sphinx#14002 (comment) for context.