Clean up double import of NetworkEventCoverageInfobar#234
Merged
huntie merged 1 commit intofacebook:mainfrom Feb 2, 2026
Merged
Clean up double import of NetworkEventCoverageInfobar#234huntie merged 1 commit intofacebook:mainfrom
huntie merged 1 commit intofacebook:mainfrom
Conversation
9834357 to
502316a
Compare
hoxyq
approved these changes
Feb 2, 2026
Member
Author
|
@hoxyq Originally planned to yeah — but think in this case keeping the now-redundant check is still a worthwhile layer of safety. Embarrassing issue if it happened again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows #232.
Removes a direct import that caused the unwanted double-registration of this component.
customElements.get()check is preserved — as this is a very low-priority component.Test plan
—
Upstreaming plan
devtools-frontendrepo following the contribution guide for Meta employees OR contribution guide.