Conversation
stefannibrasil
force-pushed
the
sb-warnings-ruby-4
branch
9 times, most recently
from
e88e993 to
42a52af
Compare
We are seeing a bunch of warnings when running the tests. Bumping bundler's version fix them. Because bundler's latest version does not support Ruby 3.0, I had to add the CI workaround until 3.0 is not supported anymore.
After bumping bundler's version, running a faker console showed these warnings: ``` faker/Rakefile:12: warning: irb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add irb to your Gemfile or gemspec to silence this warning. irb/input-method.rb:278: warning: rdoc was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add rdoc to your Gemfile or gemspec to silence this warning. ```
stefannibrasil
force-pushed
the
sb-warnings-ruby-4
branch
from
42a52af to
ef6cace
Compare
thdaraujo
approved these changes
Jan 7, 2026
stefannibrasil
added a commit
that referenced
this pull request
Jan 14, 2026
When dependabot opened a PR to update 'rdoc' version, we got a few errors in Ruby https://github.com/faker-ruby/faker/actions/runs/20980245054/job/60303497935?pr=3178 The dependency was added in github.com//pull/3165 but that deprecation warning is not generated anymore after upgrading my local ruby version to 4.0. Removing 'rdoc' from the Gemfile does not break using faker console and I don't see the warning anymore. And since 'rdoc' is part of Ruby 3.5 by default, we don't need to list it as a dependency. For anyone using Ruby < 3.5 when opening a faker console, they can install 'rdoc' as needed locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Closes #3146
Bumping Bundler version fixes the warnings when running the tests, which were a bunch. The remaining warnings when running the tests are generated from faker.
Additional information
Because Bundler's latest version does not support Ruby 3.0, I had to add the CI workaround until it is dropped. Commit messages provide more details for the additional Gemfile change.
We have one remaining warning on Ruby 4.0:
But that is coming from i18n, and should be fixed next time dependabot bumps i18n to v1.14.8.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]