👷 Add pre-commit workflow #28
Merged
+151
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriiMotov
force-pushed
the
prek
branch
2 times, most recently
from
47415ce to
fdcfb7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👷 Add pre-commit workflow
Almost same as fastapi/typer#1453, diff f2ac5c0
Plus, removed
default_language_version:andci:sections from.pre-commit-config.yamlas in https://github.com/fastapi/fastapi/pull/14397/filesIn this repo linting is run with each Python version + one more time by pre-commit:
annotated-doc/.github/workflows/test.yml
Lines 73 to 74 in 502d004
I removed that step from test.yml as we agreed