Remove inner border from popup menus#4862
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
Remove inner border from popup menus#4862devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
Co-Authored-By: John <john@hyprnote.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for char-cli-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-Authored-By: John <john@hyprnote.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
borderTailwind class from the default variant of all popup container components in the shared UI package, per design feedback to reduce visual noise. The shadow (shadow-md/shadow-lg) is retained for depth.Only the
defaultvariant is affected — theappvariant (which usesappFloatingContentClassName) is unchanged.Affected components:
DropdownMenuContentandDropdownMenuSubContentContextMenuContentandContextMenuSubContentPopoverContentReview & Testing Checklist for Human
PopoverContentconsumers outside of menus (e.g., comboboxes in settings, participant dropdowns) still look good without the border — this change is global to all default-variant popoversNotes
borderfrom Tailwind class strings in the default variant). No logic changes.appvariant is not affected since it usesappFloatingContentClassNamedirectly.Link to Devin session: https://app.devin.ai/sessions/8cc78905d7284bf6892f2aae4a80204a
Requested by: @ComputelessComputer