Skip to content

Remove inner border from popup menus#4862

Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin/1775053549-remove-popup-inner-border
Open

Remove inner border from popup menus#4862
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin/1775053549-remove-popup-inner-border

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot commented Apr 1, 2026

Summary

Removes the border Tailwind class from the default variant of all popup container components in the shared UI package, per design feedback to reduce visual noise. The shadow (shadow-md/shadow-lg) is retained for depth.

Only the default variant is affected — the app variant (which uses appFloatingContentClassName) is unchanged.

Affected components:

  • DropdownMenuContent and DropdownMenuSubContent
  • ContextMenuContent and ContextMenuSubContent
  • PopoverContent

Review & Testing Checklist for Human

  • Visually verify the overflow menu (three-dot "..." button on sessions) looks correct without the border
  • Check that PopoverContent consumers outside of menus (e.g., comboboxes in settings, participant dropdowns) still look good without the border — this change is global to all default-variant popovers
  • Right-click context menus should also be checked for visual consistency

Notes

  • This is a CSS-only change (removing border from Tailwind class strings in the default variant). No logic changes.
  • The app variant is not affected since it uses appFloatingContentClassName directly.
  • Could not visually test since the Tauri desktop app cannot run in this environment. Manual visual QA is required.

Link to Devin session: https://app.devin.ai/sessions/8cc78905d7284bf6892f2aae4a80204a
Requested by: @ComputelessComputer

Co-Authored-By: John <john@hyprnote.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for char-cli-web ready!

Name Link
🔨 Latest commit c85e2ea
🔍 Latest deploy log https://app.netlify.com/projects/char-cli-web/deploys/69cd2cc99c545300095f0530
😎 Deploy Preview https://deploy-preview-4862--char-cli-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit c85e2ea
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/69cd2cc974480900085ebbdb
😎 Deploy Preview https://deploy-preview-4862--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Co-Authored-By: John <john@hyprnote.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant