fix: speaker assignment not saving when selected from dropdown#4863
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
fix: speaker assignment not saving when selected from dropdown#4863devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Two issues in the Rust transcript rendering pipeline: 1. Auto-generated channel assignments (from participant list) were appended AFTER user assignments, causing HashMap::insert to overwrite user choices with auto-generated ones. Fix: reverse ordering so user assignments are processed last and take priority. 2. Channel-scoped assignments were gated by complete_channels, which only includes RemoteParty for exactly 2-participant meetings. For 3+ participant meetings without speaker diarization, user assignments on RemoteParty were silently ignored. Fix: remove the complete_channels gate from apply_identity_rules and assign_complete_channel_human_id so channel-wide assignments are always applied. Closes #4860 Co-Authored-By: John <john@hyprnote.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for char-cli-web canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4860. Two bugs in the Rust transcript rendering pipeline prevented user-selected speaker assignments from taking effect:
Assignment ordering: Auto-generated channel assignments (derived from the participant list) were appended after user assignments. Since
HashMap::insertoverwrites, the auto values silently replaced user choices. Fix: auto assignments are now inserted first so user assignments win.complete_channelsgate:apply_identity_rulesandassign_complete_channel_human_idboth required the channel to be incomplete_channelsbefore applying a channel-wide assignment.RemotePartyis only marked complete for exactly-2-participant meetings, so any manual speaker assignment on RemoteParty in 3+ participant meetings was silently dropped. Fix: remove thecomplete_channelsgate from both functions.Review & Testing Checklist for Human
remember_identityasymmetry is safe:remember_identity(speakers.rs ~L159) still gates carry-forward propagation oncomplete_channels. This is intentionally left to prevent one speaker's identity from overwriting the channel map for multi-speaker channels — but confirm this doesn't cause assignments to "forget" on later segments that rely on carry-forward rather than direct lookup.Notes
editor/session/index.tsxandeditor/chat/index.tsxare unrelated (NodeViewComponentPropstype issues from react-prosemirror upgrade).Link to Devin session: https://app.devin.ai/sessions/9d98abf7a843457cafc59d03a88e83e9
Requested by: @ComputelessComputer