feat(math): integrate deterministic GameMath#176
Open
fbraz3 wants to merge 6 commits into
Open
Conversation
fbraz3
force-pushed
the
feature/gamemath-deterministic
branch
3 times, most recently
from
81d2c79 to
85eca2c
Compare
Replaces standard CRT trigonometric functions with deterministic fdlibm equivalents from GameMath via FetchContent. Ensures multiplayer cross-platform replay determinism. Resolves cross-platform mismatch disconnects.
fbraz3
force-pushed
the
feature/gamemath-deterministic
branch
from
85eca2c to
8fbb570
Compare
This commit addresses remaining naked CRT calls (ceilf, floorf, sqrt) in BaseType.h, Point.h, INI.cpp, and AIPathfind.cpp that were previously missed, enforcing determinism via WWMath and fast_float wrappers to prevent cross-platform replay desyncs.
- Implement ScopedFPUGuard to restore FPU precision mode upon scope exit in MiniAudio and OpenAL audio managers. - Disable legacy RETAIL_COMPATIBLE_* macros (CRC, PATHFINDING, AIGroup, Networking, etc.) in GameDefines.h to avoid dynamic RNG/memory inconsistencies.
fbraz3
force-pushed
the
feature/gamemath-deterministic
branch
from
ab2ef61 to
c56c655
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Resolves the issue where multiplayer matches desync (Sync Mismatch / CRC error) when played across different CPU architectures (e.g. macOS ARM64 vs Linux x86_64).
The divergence occurs due to standard floating-point functions (
<math.h>) evaluating differently depending on the backend compiler and architecture (especially FMA and trig differences).Changes
CMakeListsto pullGameMathviaFetchContent.wwmath.hto redirectsin,cos,tan,acos,asin,sqrt, andatan2to usefdlibm-based deterministic functions.