Repository navigation
Add actor generation form - #74
Merged
Merged
Conversation
sij411
marked this pull request as draft
September 8, 2026 15:11
sij411
force-pushed
the
feat/actor-page
branch
from
September 8, 2026 15:18
99fe1a6 to
68d9e61
Compare
Member
Author
|
Testing in progress |
Member
Author
|
Currently, after creating actor, it stays on the actor creating page. Should i add some post actions? 
|
sij411
marked this pull request as ready for review
September 9, 2026 05:06
dodok8
previously approved these changes
Sep 9, 2026
Member
|
How about add 'useNavigate'? |
Member
Author
|
@dodok8 navigate to instance detail page? |
Member
|
Yes. |
dodok8
requested changes
Sep 11, 2026
2chanhaeng
reviewed
Sep 12, 2026
2chanhaeng
reviewed
Sep 13, 2026
sij411
force-pushed
the
feat/actor-page
branch
from
September 15, 2026 05:39
49c3d6c to
4e8b429
Compare
Member
Author
|
local actors list and the success toast after redirected to instance detail page from creating actor form page. 
|
I implemented the actor-generation route with Formisch and Valibot validation, Kobalte controls, Relay global-ID mutation input, loading state, and distinct GraphQL, domain, and network error handling. Codex reviewed and explained the Relay and generated-type behavior, then made focused edits to route Kobalte numeric values into Formisch, correct a generated import suffix and typo, and resolve lint findings. I retained the design and implementation decisions. Codex ran the full repository check successfully. I will manually verify the UI before submitting the pull request. Assisted-by: Codex:gpt-5.6-sol
I pinned Seroval 1.5.4 in the web package so Solid Relay uses the same OpaqueReference implementation as Solid SSR, preventing serialization failures when entering preloaded dynamic routes. Codex diagnosed the upstream peer-version mismatch and applied the dependency and lockfile changes. I confirmed the fix in the development environment by entering the instance route and observing its GraphQL query execute normally. Codex ran mise run check, mise run build, mise run test, and an SSR request to the affected dynamic route successfully. Assisted-by: Codex:gpt-5.6-sol
Navigate to the selected instance by slug after actor creation and refresh its cached actor list. Add a persistent Kobalte toast region with a dismissible success notification. Use the number field rawValue prop so clearing the actor count leaves the input editable. Codex generated these changes at my request. I verified that the toast worked and reported the empty-input NaN bug, which guided the subsequent input fix. The input fix has not been browser-verified. Validation: mise run check and mise run test (including the build) passed; lint reports a callback statement-count warning. Assisted-by: Codex:gpt-6-astra
Load the instance detail page afresh after creating actors and carry the success toast through session storage so it appears on the destination once. Normalize empty actor-count input to keep the size field editable. Codex generated these changes at my request after I reported stale instance details and an uneditable size field. I requested a full page refresh and verified that the resulting changes worked in the browser. Assisted-by: Codex:gpt-6-astra
Add status-specific toast colors and preserve the message and status across full-page navigation. Parse and validate saved notifications with a single Valibot pipeline, and pass success explicitly after actor creation. Codex updated the toast related helpers and the caller with success and failure varaints. I added Valibot and css. I verified the resulting changes in the browser. Assisted-by: Codex:gpt-6-astra
sij411
force-pushed
the
feat/actor-page
branch
from
September 15, 2026 07:15
9caaf3f to
e8efa26
Compare
dodok8
approved these changes
Sep 15, 2026
2chanhaeng
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41
AI assistance
Used Codex (
gpt-5.6-sol) to review the Relay/Formisch/Kobalte integration and make focused corrections to numeric input binding, an import suffix, a typo, and lint issues. I reviewed and retained the design and implementation decisions.