Draft
Conversation
|
|
||
| def expand_tox(text): | ||
| """Replace [[TOX4:...]] and [[TOX3:...]] expressions, | ||
| empty liens are stripped if created.""" |
Member
There was a problem hiding this comment.
Suggested change
| empty liens are stripped if created.""" | |
| empty lines are stripped if created.""" |
| empty liens are stripped if created.""" | ||
| source_lines = text.splitlines() | ||
| out_lines = [] | ||
| for line in source_lines: |
Member
There was a problem hiding this comment.
Only this loop is kinda cryptic. I'd add comments saying that the first if not line is there to preserve empty lines in the original output and the second if line is there to avoid adding more empty lines if one of the inline expressions creates one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
Opening as a draft. I can continue this way with more tests, but i wanted to know from @frenzymadness if this approach makes sense or is too cryptic.