Skip to content

Filters buttons#10

Closed
LaMendolaThomas wants to merge 3 commits intofeenkcom:mainfrom
LaMendolaThomas:feature-filters
Closed

Filters buttons#10
LaMendolaThomas wants to merge 3 commits intofeenkcom:mainfrom
LaMendolaThomas:feature-filters

Conversation

@LaMendolaThomas
Copy link
Copy Markdown

image
I implemented a feature that allows to quickly add and remove filters without having to use the dropdown menu, making the process more seamless and faster. As implemented now there is an example for the "instance methods" filters as shown in the screenshot. By clicking on the button, the filter is added and then removed by clicking again.

@feenk-cla-helper
Copy link
Copy Markdown

[This is an automated comment from the feenk Contributor License Agreement robot.]

Hello LaMendolaThomas!

Thanks for your interest in making software development better. Please sign the feenk Contributor License Agreement so we can investigate merging in your work.

@edward
Copy link
Copy Markdown

edward commented Aug 21, 2024

Hello and thanks for your PR!

Your signature of the feenk CLA has been registered, so this PR is now ready to be investigated for merging by feenk staff.

The next time you open a PR, it should be green and good to go. (A bug currently leaves the feenk Contributor License Agreement check as failed but it can be safely ignored.)

@girba
Copy link
Copy Markdown
Member

girba commented Aug 21, 2024

Thank you for the suggestion. We are now working on a rewrite of filters.

@JurajKubelka
Copy link
Copy Markdown
Member

We do not use this filter implementation anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants