fix(e2e): retry and fail loudly when clearing Firebase Auth emulator data - #2443
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces handling for GetCredentialCancellationException when a user dismisses the Google Credential Manager sheet, transitioning the state to AuthState.Cancelled instead of throwing an error. It also refactors ErrorRecoveryDialog helper functions to be internal for direct testing, cleans up duplicate test helpers, and adds robust retry logic with error propagation when clearing emulator data in tests. Feedback is provided regarding the emulator retry loop, where catching a generic Exception can swallow InterruptedException from Thread.sleep; it is recommended to explicitly handle and restore the thread's interrupted status.
demolaf
marked this pull request as ready for review
August 7, 2026 12:16
demolaf
force-pushed
the
fix/e2e-emulator-clear-retry
branch
from
August 17, 2026 18:08
a87cfe3 to
a304bff
Compare
github-project-automation
Bot
moved this from Backlog
to Done
in studio-2394994192-60a69
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flaky
CredentialLinkingScreenTestGoogle-link test on CI by makingEmulatorAuthApi.clearEmulatorData()retry with backoff and throw on failure instead of silently leaving stale emulator state.