Skip to content

feat: email link sign in should have separate way to enable #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
russellwheatley wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: email link sign in should have separate way to enable #1321

russellwheatley wants to merge 4 commits into from

Conversation

@russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Dec 16, 2025

fixes #1318

  • separate email/password and email link sign in by creating separate method for email link sign-in.
  • still allow callback for email link if the user wants to use default Views partially (i.e. renderButtons()), but would prefer email link button to navigate to custom route.
  • test all providers appear when configured and don't appear when not configured.

@russellwheatley russellwheatley marked this pull request as ready for review December 16, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

@demolaf demolaf demolaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Email sign-in without link is not possible in FirebaseAuthSwiftUI

3 participants

@russellwheatley @morganchen12 @demolaf