Skip to content

Add javadocs to public methods in RC managed value types#1187

Merged
jonathanedey merged 1 commit intomainfrom
kotharas/rc-managed-values-docs
Feb 25, 2026
Merged

Add javadocs to public methods in RC managed value types#1187
jonathanedey merged 1 commit intomainfrom
kotharas/rc-managed-values-docs

Conversation

@ashish-kothari
Copy link
Contributor

Adds javadocs to newly introduced managed value types in RC (#1167).

@gemini-code-assist
Copy link

Summary of Changes

Hello @ashish-kothari, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the developer experience by providing comprehensive Javadoc documentation for the public methods of newly introduced managed value types within the Remote Config (RC) module. This ensures that developers can easily understand the purpose and usage of these methods, improving code clarity and maintainability.

Highlights

  • Documentation: Added Javadoc comments to public getter methods within the RolloutValue, PersonalizationValue, ExperimentVariantValue, and ExperimentValue nested classes in ParameterValue.java.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/main/java/com/google/firebase/remoteconfig/ParameterValue.java
    • Added Javadoc comments to getRolloutId(), getValue(), and getPercent() methods in RolloutValue.
    • Added Javadoc comments to getPersonalizationId() method in PersonalizationValue.
    • Added Javadoc comments to getVariantId(), getValue(), and isNoChange() methods in ExperimentVariantValue.
    • Added Javadoc comments to getExperimentId() and getExperimentVariantValues() methods in ExperimentValue.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully adds Javadocs to the public methods of the newly introduced managed value types in ParameterValue.java. The added documentation is clear, concise, and correctly formatted, enhancing the readability and maintainability of the code. No further issues or improvements of medium, high, or critical severity were identified.

@jonathanedey jonathanedey merged commit a568b65 into main Feb 25, 2026
7 checks passed
@jonathanedey jonathanedey deleted the kotharas/rc-managed-values-docs branch February 25, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants