Adjust how prereqs are downloaded - #1901
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Android prerequisite installation script by adding cleanup steps before downloading, using the -f flag with curl, and reducing the retry sleep interval from 300 to 10 seconds. The review feedback suggests cleaning up partially downloaded files within the error exit blocks to avoid leaving corrupted files behind, and increasing the retry sleep duration from 10 to 30 seconds to better handle transient network issues.
cynthiajoan
approved these changes
Aug 3, 2026
github-actions
Bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @a-maurice on commit 7262df9
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
Bot
removed
the
tests: in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Binutils keeps having some flakiness around downloading. Change it to try other mirrors, and fail with an error code if there is a problem.
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.