Skip to content

Revert Emulator Overlay Changes#9596

Closed
dlarocque wants to merge 2 commits intomainfrom
dl/revert-innerhtml
Closed

Revert Emulator Overlay Changes#9596
dlarocque wants to merge 2 commits intomainfrom
dl/revert-innerhtml

Conversation

@dlarocque
Copy link
Copy Markdown
Contributor

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 25, 2026

⚠️ No Changeset found

Latest commit: 6fa1d6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @dlarocque, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts the previously introduced emulator overlay functionality. It systematically removes the updateEmulatorBanner function and its related UI components, which were designed to display a visual banner when Firebase SDKs were connected to an emulator, particularly in cloud workstation environments. This change cleans up the codebase by eliminating unused imports and function calls across multiple Firebase packages, effectively undoing the visual indicator for emulator connections.

Highlights

  • Removed Emulator Banner Logic: The updateEmulatorBanner function and all its associated UI logic for displaying an emulator overlay banner have been completely removed from the @firebase/util package.
  • Cleaned Up SDK Integrations: Imports and calls to the updateEmulatorBanner function were removed from the Auth, Database, Firestore, Functions, and Storage SDK packages, streamlining their emulator connection logic.
  • Simplified Ping Server Calls: In Functions and Storage SDKs, the pingServer calls were simplified by removing specific path suffixes (/backends and /b), as the updateEmulatorBanner function which used these paths is no longer present.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • common/api-review/util.api.md
    • Removed the API definition for updateEmulatorBanner.
  • packages/auth/src/core/auth/emulator.ts
    • Removed the import and calls to updateEmulatorBanner, and adjusted the warning emission logic.
  • packages/database/src/api/Database.ts
    • Removed the import and calls to updateEmulatorBanner.
  • packages/firestore/src/lite-api/database.ts
    • Removed the import and calls to updateEmulatorBanner.
  • packages/functions/src/service.ts
    • Removed the import and calls to updateEmulatorBanner, and simplified the pingServer endpoint.
  • packages/storage/src/service.ts
    • Removed the import and calls to updateEmulatorBanner, and simplified the pingServer endpoint.
  • packages/util/src/emulator.ts
    • Deleted the entire updateEmulatorBanner function and all its supporting helper functions and state, along with an unused import.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the 'Emulator Overlay' feature. The changes consistently remove the updateEmulatorBanner function, its implementation in @firebase/util, and its usage across the auth, database, firestore, functions, and storage packages. The API review file is also updated accordingly. The modifications to pingServer calls in the functions and storage packages also appear to be part of this revert, restoring previous endpoint paths. The changes are clean and focused on the revert, and I see no issues.

@dlarocque dlarocque closed this Feb 27, 2026
@firebase firebase locked and limited conversation to collaborators Mar 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant