docs: fix code snippets that do not compile#18468
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@googlebot I signed it! |
5eabee2 to
489b775
Compare
|
Hi @meliharik, thanks for the contribution. LGTM! |
Four documentation snippets do not parse as written. Each was verified with
dart format --output=none: the block fails to parse before the change and parses after it.Dartdoc — unterminated string
packages/firebase_core/firebase_core_web/lib/src/firebase_app_web.dart:14packages/firebase_core/firebase_core_platform_interface/lib/src/method_channel/method_channel_firebase_app.dart:14Both files close the string with a backtick instead of
'. Same line, same typo, presumably copied between the two.The web file also says "call the the
appmethod" one line above, fixed here too.docs/perf-mon/_custom-code-traces.md:154— doubled parenTo be explicit about intent: the "Don't do this!" warning is about putting personally identifiable information in an attribute, not about the syntax — the "OK" example seven lines above is
putAttribute("experiment", "A");with a single paren. The extra(is unintended.docs/auth/email-link-auth.md:102— leftover closing.then((value) => print('Successfully sent email verification')); -});The statement already terminates with
;on the previous line; the});has no matching opener inside the block.How I found them
I extracted every fenced code block and
///doc comment across the repo and checked paren/bracket balance outside strings and comments, then read each hit in context to separate real typos from intentional fragments. Docs-only change — no behaviour, no tests affected.