Skip to content

Auto-update dependencies. - #2852

Open
dpebot wants to merge 1 commit into
masterfrom
dpebot-repositorygardener
Open

dpebot wants to merge 1 commit into
masterfrom
dpebot-repositorygardener

Conversation

@dpebot

@dpebot dpebot commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Brought to you by your friendly Repository Gardener.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Firebase BoM version from 35.0.2 to 35.1.0 across various module build files and the Gradle version catalog, alongside minor updates to Firebase AI dependencies. Feedback suggests leveraging the centralized Gradle Version Catalog (libs.firebase.bom) in the module build files instead of hardcoding the version string to improve maintainability.


// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:35.0.2"))
implementation(platform("com.google.firebase:firebase-bom:35.1.0"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of hardcoding the Firebase BoM version in each module's build file, leverage the Gradle Version Catalog dependency libs.firebase.bom which is already defined in gradle/libs.versions.toml. This centralizes dependency management and ensures that future updates only need to be made in a single place.

    implementation(platform(libs.firebase.bom))


// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:35.0.2"))
implementation(platform("com.google.firebase:firebase-bom:35.1.0"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of hardcoding the Firebase BoM version in each module's build file, leverage the Gradle Version Catalog dependency libs.firebase.bom which is already defined in gradle/libs.versions.toml. This centralizes dependency management and ensures that future updates only need to be made in a single place.

    implementation(platform(libs.firebase.bom))

Comment thread auth/app/build.gradle.kts

// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:35.0.2"))
implementation(platform("com.google.firebase:firebase-bom:35.1.0"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of hardcoding the Firebase BoM version in each module's build file, leverage the Gradle Version Catalog dependency libs.firebase.bom which is already defined in gradle/libs.versions.toml. This centralizes dependency management and ensures that future updates only need to be made in a single place.

    implementation(platform(libs.firebase.bom))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant