fix(thrift): add TEnumIterator::operator== for libc++ 22#38
Open
kop wants to merge 1 commit into
Open
Conversation
libc++ >= 19 implements std::map's range constructor with `first == last`. arrow's vendored thrift TEnumIterator only declared operator!=, so std::map<int,const char*>(TEnumIterator,...) in the generated parquet_types.cpp failed to compile under the LLVM 22 toolchain. Add the matching operator==. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
PackDB is migrating its CMake build to Clang 22 + libc++ 22 (FB-1819). libc++ >= 19 implements
std::map's range constructor with `first == last`.
Summary
arrow's vendored thrift `TEnumIterator` only declared `operator!=`, so
`std::map<int,const char*>(TEnumIterator,...)` in the generated `parquet_types.cpp` failed to compile
under the LLVM 22 toolchain. Add the matching `operator==`.
Test Plan