-
Notifications
You must be signed in to change notification settings - Fork 453
Add a Focus Self transform #5774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d18cff3 to
62f75cd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5774 +/- ##
==========================================
- Coverage 85.64% 85.62% -0.02%
==========================================
Files 319 319
Lines 31197 31247 +50
Branches 8588 8510 -78
==========================================
+ Hits 26718 26756 +38
- Misses 4049 4061 +12
Partials 430 430 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fec7650 to
c470427
Compare
| .title = { CallNodeContextMenu--transform-focus-function-title } | ||
| CallNodeContextMenu--transform-focus-function-inverted = Focus on function (inverted) | ||
| .title = { CallNodeContextMenu--transform-focus-function-title } | ||
| CallNodeContextMenu--transform-focus-self-title = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we expect self to be translated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on how the call tree's "Self" column is translated. I've added the following note, does that work?
# The translation for "self" in this string should match the translation used
# in CallTree--samples-self and CallTree--bytes-self. Alternatively it can be
# translated as "self values" or "self time" (though "self time" is less desirable
# because this menu item is also shown in "bytes" mode).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The note works, but we should add it also for the previous string. You can use a group-level comment (2 hashes), and reset it after this string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
er wait, I did it wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry about that, should be good now
4eb37eb to
5450567
Compare
| # $item (String) - Name of the function that transform applied to. | ||
| TransformNavigator--focus-function = Focus: { $item } | ||
| # "Focus self" transform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, worth adding a short note on "self" (no need for it to be as long as the other).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, how does this look?
5d63c03 to
7299b85
Compare
flodolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
canova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the documentation and localization!
src/profile-logic/transforms.ts
Outdated
| case 'focus-function': | ||
| return _startCallNodePathWithFunction(transform.funcIndex, callNodePath); | ||
| case 'focus-self': | ||
| return _startCallNodePathWithFunction(transform.funcIndex, callNodePath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could you add a comment here maybe explaining why we still keep all the descendant call nodes? I was a bit confused by that at first, but then it made sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops actually I think I forgot to properly review this part. It doesn't make sense to me. Thanks for catching this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I thought it was actually doing it because we had the implementation filter applied later. It appears I was wrong.
This transform avoids the need to drop callees manually if you want to see a flame graph for a single JS function but no other JS functions; with this transform, you can focus on the function's self while you're in the JS-only view, and then go back to the combined view to see any native functions involved in the execution of that JS function.
7299b85 to
35c005e
Compare
Lots of exciting changes 🎉: [arai-a] Put radio buttons into labels (#5738) [DaniPopes] Update comment for "unique-string" (#5741) [Karan Pradhan] Hide tooltip filter button in non-sticky tooltips and add hideFilterButton tests (#5718) [arai-a] Add a menu to copy the Marker Table as text (#5732) [arai-a] Make the entire list item clickable for the "Full Range" (#5742) [Markus Stange] Move symbol table demangling out of SymbolStore into SymbolProvider (#5746) [Markus Stange] Remove SVG asset imports from profile-data.ts (#5747) [arai-a] Do not apply sticky tooltip on double click (#5754) [arai-a] Skip the ChartCanvas redraw on the Viewport's internal default state usage (#5744) [Markus Stange] Stop blindly extracting uint8array.buffer after calling compress() (#5753) [Markus Stange] In the assembly view state, refer to the current symbol by index (#5755) [Markus Stange] Fix "scroll to hotspot" functionality in the source view + assembly view (#5759) [Markus Stange] Keep the colorField markerSchema field when processing profiles in the gecko format (#5760) [Markus Stange] Implement dark mode (#5740) [Markus Stange] Fix light-mode colors (#5765) [Markus Stange] Tweak dark mode colours. (#5767) [Nazım Can Altınova] Enable some basic type-aware lints (#5775) [Markus Stange] Allow seeing different assembly code for the same function (#5349) [fatadel] Refine tree view a11y (#5779) [fatadel] Align double-click behavior of stack chart with flame graph (#5782) [Markus Stange] Split gz.ts properly into node and browser variants (#5764) [Markus Stange] Simplify and optimize the computation of per-call-node line and address timings (#5770) [Nazım Can Altınova] Move the dark mode toggle to devtools console (#5783) [Nazım Can Altınova] 🔃 Sync: l10n -> main (Jan 27, 2026) (#5785) [Nazım Can Altınova] Improve Chrome importer marker payload logic (#5717) [Markus Stange] Add a Focus Self transform (#5774) [Nazım Can Altınova] Enable the Turkish locale in production (#5786) And huge thanks to our localizers 🎉 : be: Mikalai Udodau de: Ger de: Michael Köhler el: Jim Spentzos en-CA: chutten en-CA: Saurabh en-GB: Ian Neal en-GB: Saurabh es-CL: ravmn fy-NL, nl: Fjoerfoks fr: Skywarp fr: Théo Chevalier fur: Fabio Tomat fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Fjoerfoks nl: Mark Heijl pt-BR: Marcelo Ghelman ru: berry ru: Valery Ledovskoy sv-SE: Andreas Pettersson tr: Grk zh-CN: Olvcpr423 zh-CN: wxie zh-TW: Pin-guang Chen
Deploy preview
This transform avoids the need to drop callees manually if you want to see a flame graph for a single JS function but no other JS functions. With this transform, you can focus on the function's self while you're in the JS-only view, and then go back to the combined view to see any native functions involved in the execution of that JS function.
For example, in this profile, you can "focus self" on
HTMLElement.click, and then change the implementation filter to "All Frames". This will show you the overhead on the way to calling the click handler, minus the time spent in the called JS code (profile). If you had just done "focus function" onHTMLElement.click, you would have seen all the time spent in callees too (profile), and you would have needed to drop each JS callee manually.