Use "falls through" for all fallthrough comments - #6344
Merged
Merged
Conversation
I was experimenting with oxlint, and oxlint's check needs the verbatim "falls through" spelling (unless we want to customize the pattern).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6344 +/- ##
========================================
Coverage 84.11% 84.11%
========================================
Files 356 356
Lines 38444 38444
Branches 10786 10887 +101
========================================
Hits 32339 32339
Misses 5676 5676
Partials 429 429 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
canova
approved these changes
Sep 23, 2026
mstange
enabled auto-merge
September 23, 2026 14:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
I was experimenting with oxlint, and oxlint's check needs the verbatim "falls through" spelling (unless we want to customize the pattern).