Add missing await when calling Chrome importer - #6346
Merged
Merged
Conversation
attemptToConvertChromeProfile is the only importer that returns a promise rather than a finished profile. We were returning the promise without an await, so any exceptions from it would bypass our error wrapping and the console.error call.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6346 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 356 356
Lines 38444 38444
Branches 10786 10786
=======================================
Hits 32339 32339
Misses 5676 5676
Partials 429 429 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
canova
approved these changes
Sep 23, 2026
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
Ah, classic non-awaited promise inside a try footgun.. Does oxlint have a rule to catch it? It would be nice to have that rule if so.
mstange
enabled auto-merge
September 23, 2026 13:58
Contributor
Author
I'm not sure, need to check. Claude found this issue during the oxlint experiment but I don't know if it was from code inspection or from a lint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
attemptToConvertChromeProfile is the only importer that returns a promise rather than a finished profile.
We were returning the promise without an await, so any exceptions from it would bypass our error wrapping and the console.error call.