Serve production build by default during local development - #6353
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6353 +/- ##
=======================================
Coverage 84.11% 84.12%
=======================================
Files 356 356
Lines 38444 38445 +1
Branches 10887 10888 +1
=======================================
+ Hits 32339 32340 +1
Misses 5676 5676
Partials 429 429 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fixes firefox-devtools#6332. Now we have: * `yarn start`: production build, no service worker, port 4242 * `yarn start-prod`: production build, with service worker, port 4243 * `yarn start-dev`: development build, no service worker, port 4241 There's a bit of churn in how the filenames are determined. In the past, we were putting a hash in the filenames whenever we were building for production, including for the source map worker, and we didn't have a way to "watch" the production build. Now that `yarn start` is a "watched" production build, we need to make sure that the source map worker filename does not contain a hash, otherwise the path to it that gets embedded into the main bundle would get out of sync. The main bundle still uses a hashed filename; each rebuild updates index.html with the new path. (It's not straightforward to use a similar mechanism for the worker, because the worker and the main bundle run in separate esbuild watch contexts.)
mstange
force-pushed
the
push-nrkysnrvtnwl
branch
from
September 23, 2026 19:53
346232b to
c9c049c
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
Fixes #6332.
Now we have:
yarn start: production build, no service worker, port 4242yarn start-prod: production build, with service worker, port 4243yarn start-dev: development build, no service worker, port 4241There's a bit of churn in how the filenames are determined. In the past, we were putting a hash in the filenames whenever we were building for production, including for the source map worker, and we didn't have a way to "watch" the production build.
Now that
yarn startis a "watched" production build, we need to make sure that the source map worker filename does not contain a hash, otherwise the path to it that gets embedded into the main bundle would get out of sync.The main bundle still uses a hashed filename; each rebuild updates index.html with the new path. (It's not straightforward to use a similar mechanism for the worker, because the worker and the main bundle run in separate esbuild watch contexts.)