Skip to content

[PWGEM] Please consider the following formatting changes to #15715 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alibuild wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

[PWGEM] Please consider the following formatting changes to #15715 #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions PWGEM/PhotonMeson/Tasks/emcalPi0Qc.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
photon.SetPxPyPzE(px, py, pz, energy);
id = clusid;
sm = sm_tmp;
onDCal = (phi < 6 && phi > 4);

Check failure on line 83 in PWGEM/PhotonMeson/Tasks/emcalPi0Qc.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
}

ROOT::Math::PxPyPzEVector photon;
Expand Down Expand Up @@ -288,7 +288,7 @@
}

// add histograms per supermodule
for (int ism = 0; ism < 20; ++ism) {

Check failure on line 291 in PWGEM/PhotonMeson/Tasks/emcalPi0Qc.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
mHistManager.add(Form("clusterTimeVsTimeStamp/clusterTimeVsTimeStampSM%d", ism), Form("Cluster time vs collision timestamp in Supermodule %d", ism), HistType::kTH2F, {clusterTimeAxis, collisionTimeAxis}, mDoSumw2.value);
mHistManager.add(Form("clusterNcellVsTimeStamp/clusterNCellVsTimeStampSM%d", ism), Form("Cluster number of cells vs collision timestamp in Supermodule %d", ism), HistType::kTH2F, {{50, 0, 50}, collisionTimeAxis}, mDoSumw2.value);
mHistManager.add(Form("clusterM02VsTimeStamp/clusterM02VsTimeStampSM%d", ism), Form("Cluster M02 vs collision timestamp in Supermodule %d", ism), HistType::kTH2F, {{400, 0, 5}, collisionTimeAxis}, mDoSumw2.value);
Expand Down Expand Up @@ -541,13 +541,13 @@
if (mDoEventSel.value && (!collision.sel8())) { // Check sel8
continue;
}
mHistManager.fill(HIST("events"), 2);
mHistManager.fill(HIST("events"), 2);
if (mRequireCaloReadout.value && !(collision.alias_bit(kTVXinEMC) || collision.alias_bit(kEMC7) || collision.alias_bit(kDMC7) || collision.alias_bit(kEG1) || collision.alias_bit(kEG2) || collision.alias_bit(kDG1) || collision.alias_bit(kDG2) || collision.alias_bit(kEJ1) || collision.alias_bit(kEJ2) || collision.alias_bit(kDJ1) || collision.alias_bit(kDJ2))) { // Check whether EMC was read out
continue;
}
mHistManager.fill(HIST("events"), 3); // Fill readout

if (mDoEventSel.value && collision.numContrib() < 0.5) { // Skip collisions without contributors

Check failure on line 550 in PWGEM/PhotonMeson/Tasks/emcalPi0Qc.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
continue;
}
mHistManager.fill(HIST("events"), 4); // Fill >1 vtx contr. bin of event histogram
Expand Down Expand Up @@ -671,14 +671,14 @@
continue;
}

mHistManager.fill(HIST("events"), 2, mWeight); // Fill sel8
mHistManager.fill(HIST("eventsWithoutWeight"), 3); // Fill sel8 bin of event histogram without weight
mHistManager.fill(HIST("events"), 2, mWeight); // Fill sel8
mHistManager.fill(HIST("eventsWithoutWeight"), 3); // Fill sel8 bin of event histogram without weight
if (mRequireCaloReadout.value && !(collision.alias_bit(kTVXinEMC) || collision.alias_bit(kEMC7) || collision.alias_bit(kDMC7) || collision.alias_bit(kEG1) || collision.alias_bit(kEG2) || collision.alias_bit(kDG1) || collision.alias_bit(kDG2) || collision.alias_bit(kEJ1) || collision.alias_bit(kEJ2) || collision.alias_bit(kDJ1) || collision.alias_bit(kDJ2))) { // Check whether EMC was read out
continue;
}
mHistManager.fill(HIST("events"), 3, mWeight); // Fill readout
mHistManager.fill(HIST("eventsWithoutWeight"), 4); // Fill readout bin of event histogram without weight
if (mDoEventSel.value && collision.numContrib() < 0.5) { // Skip collisions without contributors

Check failure on line 681 in PWGEM/PhotonMeson/Tasks/emcalPi0Qc.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
continue;
}
mHistManager.fill(HIST("events"), 4, mWeight); // Fill >1 vtx contr. bin of event histogram
Expand Down Expand Up @@ -871,7 +871,7 @@
LOG(debug) << "processMesons " << mPhotons.size();

// if less then 2 clusters are found, skip event
if (mPhotons.size() < 2)

Check failure on line 874 in PWGEM/PhotonMeson/Tasks/emcalPi0Qc.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return;

// loop over all photon combinations and build meson candidates
Expand Down Expand Up @@ -912,7 +912,7 @@
void calculateBackground(const Meson& meson, unsigned int ig1, unsigned int ig2)
{
// if less than 3 clusters are present, skip event
if (mPhotons.size() < 3) {

Check failure on line 915 in PWGEM/PhotonMeson/Tasks/emcalPi0Qc.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return;
}
const double rotationAngle = o2::constants::math::PIHalf; // 0.78539816339; // rotaion angle 90°
Expand Down Expand Up @@ -1000,11 +1000,11 @@
int nBinsPt = 179;
double maxPt = 60;
for (int i = 0; i < nBinsPt + 1; i++) {
if (i < 100) {

Check failure on line 1003 in PWGEM/PhotonMeson/Tasks/emcalPi0Qc.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
result.emplace_back(0.10 * i);
} else if (i < 140) {

Check failure on line 1005 in PWGEM/PhotonMeson/Tasks/emcalPi0Qc.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
result.emplace_back(10. + 0.25 * (i - 100));
} else if (i < 180) {

Check failure on line 1007 in PWGEM/PhotonMeson/Tasks/emcalPi0Qc.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
result.emplace_back(20. + 1.00 * (i - 140));
} else {
result.emplace_back(maxPt);
Expand Down
Loading