Skip to content

Fleet UI: Add "Learn more" link to End-user Authentication docs on SSO settings page#42814

Merged
getvictor merged 3 commits intomainfrom
copilot/add-docs-links-to-sso-page
Apr 1, 2026
Merged

Fleet UI: Add "Learn more" link to End-user Authentication docs on SSO settings page#42814
getvictor merged 3 commits intomainfrom
copilot/add-docs-links-to-sso-page

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

Resolves #40164

Manually verified:
image

Adds a "Learn more" link to the End-user Authentication documentation on the /settings/integrations/sso/end-users page, making it easier for customers to reference docs while configuring SSO settings.

  • EndUserAuthSection.tsx: Appended a Learn more anchor (opens in new tab) after the description text in the end-user auth settings card.

Summary by CodeRabbit

  • New Features
    • Added a "Learn more" link in the end user authentication setup section, providing quick access to comprehensive setup guidance and documentation.

Copilot AI linked an issue Apr 1, 2026 that may be closed by this pull request
1 task
fleet-release
fleet-release previously approved these changes Apr 1, 2026
Copilot AI changed the title [WIP] Add links to documentation on /settings/integrations/sso/end-users Fleet UI: Add "Learn more" link to End-user Authentication docs on SSO settings page Apr 1, 2026
Copilot AI requested a review from getvictor April 1, 2026 15:27
@getvictor getvictor requested a review from Copilot April 1, 2026 15:36
@getvictor
Copy link
Copy Markdown
Member

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

✅ Actions performed

Full review triggered.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.81%. Comparing base (03ecdb1) to head (ab1ef53).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #42814    +/-   ##
========================================
  Coverage   66.81%   66.81%            
========================================
  Files        2541     2541            
  Lines      203971   203971            
  Branches     9278     9164   -114     
========================================
  Hits       136282   136282            
  Misses      55343    55343            
  Partials    12346    12346            
Flag Coverage Δ
frontend 54.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an easy-to-find documentation link on the SSO end-user authentication settings page so admins can quickly reference Fleet’s End-user Authentication setup guidance while configuring IdP settings.

Changes:

  • Appends a “Learn more” external link to the End-user Authentication docs in the End User Authentication section description.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

Walkthrough

The EndUserAuthSection component's UI copy was updated to include a "Learn more" external link. The link, pointing to the end user authentication setup experience guide at https://fleetdm.com/guides/setup-experience#end-user-authentication, was appended to the existing text that previously concluded with "their host." The link opens in a new tab with appropriate security attributes (target="_blank" and rel="noreferrer").

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description lacks critical checklist items completion; most are unchecked without justification for a code change. Complete the submitter checklist by checking relevant boxes or explaining why items don't apply. For example, confirm if a changes file is needed for this UI update, clarify testing approach, and confirm no security concerns.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: adding a 'Learn more' link to End-user Authentication docs on the SSO settings page.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch copilot/add-docs-links-to-sso-page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
frontend/pages/admin/IntegrationsPage/cards/IdentityProviders/components/EndUserAuthSection/EndUserAuthSection.tsx (1)

148-148: Consider adding noopener to the rel attribute.

While noreferrer already provides security benefits, adding noopener explicitly prevents the opened page from accessing window.opener, providing defense-in-depth.

🔒 Suggested enhancement
-            rel="noreferrer"
+            rel="noopener noreferrer"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@frontend/pages/admin/IntegrationsPage/cards/IdentityProviders/components/EndUserAuthSection/EndUserAuthSection.tsx`
at line 148, The anchor in EndUserAuthSection (EndUserAuthSection.tsx) currently
sets rel="noreferrer"; update the rel attribute to include noopener (e.g.,
rel="noreferrer noopener") on the same <a> element to ensure the opened page
cannot access window.opener, keeping the rest of the link attributes and
behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@frontend/pages/admin/IntegrationsPage/cards/IdentityProviders/components/EndUserAuthSection/EndUserAuthSection.tsx`:
- Line 148: The anchor in EndUserAuthSection (EndUserAuthSection.tsx) currently
sets rel="noreferrer"; update the rel attribute to include noopener (e.g.,
rel="noreferrer noopener") on the same <a> element to ensure the opened page
cannot access window.opener, keeping the rest of the link attributes and
behavior unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 69a1495c-65d8-4549-b0d7-ff7a5429bb1d

📥 Commits

Reviewing files that changed from the base of the PR and between 03ecdb1 and abab22f.

📒 Files selected for processing (1)
  • frontend/pages/admin/IntegrationsPage/cards/IdentityProviders/components/EndUserAuthSection/EndUserAuthSection.tsx

@getvictor getvictor marked this pull request as ready for review April 1, 2026 15:45
@getvictor getvictor requested a review from a team as a code owner April 1, 2026 15:45
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Member

@dantecatalfamo dantecatalfamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big change, took a long time to review

@getvictor getvictor merged commit 511e042 into main Apr 1, 2026
19 checks passed
@getvictor getvictor deleted the copilot/add-docs-links-to-sso-page branch April 1, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update copy and link to guide in Settings > Integrations

5 participants