Fleet UI: Add "Learn more" link to End-user Authentication docs on SSO settings page#42814
Fleet UI: Add "Learn more" link to End-user Authentication docs on SSO settings page#42814
Conversation
…tion Agent-Logs-Url: https://github.com/fleetdm/fleet/sessions/7bf05736-e7f2-42e4-b56f-349cb7c930d0 Co-authored-by: getvictor <2685025+getvictor@users.noreply.github.com>
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #42814 +/- ##
========================================
Coverage 66.81% 66.81%
========================================
Files 2541 2541
Lines 203971 203971
Branches 9278 9164 -114
========================================
Hits 136282 136282
Misses 55343 55343
Partials 12346 12346
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds an easy-to-find documentation link on the SSO end-user authentication settings page so admins can quickly reference Fleet’s End-user Authentication setup guidance while configuring IdP settings.
Changes:
- Appends a “Learn more” external link to the End-user Authentication docs in the End User Authentication section description.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ntegrationsPage/cards/IdentityProviders/components/EndUserAuthSection/EndUserAuthSection.tsx
Outdated
Show resolved
Hide resolved
WalkthroughThe 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
frontend/pages/admin/IntegrationsPage/cards/IdentityProviders/components/EndUserAuthSection/EndUserAuthSection.tsx (1)
148-148: Consider addingnoopenerto therelattribute.While
noreferreralready provides security benefits, addingnoopenerexplicitly prevents the opened page from accessingwindow.opener, providing defense-in-depth.🔒 Suggested enhancement
- rel="noreferrer" + rel="noopener noreferrer"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@frontend/pages/admin/IntegrationsPage/cards/IdentityProviders/components/EndUserAuthSection/EndUserAuthSection.tsx` at line 148, The anchor in EndUserAuthSection (EndUserAuthSection.tsx) currently sets rel="noreferrer"; update the rel attribute to include noopener (e.g., rel="noreferrer noopener") on the same <a> element to ensure the opened page cannot access window.opener, keeping the rest of the link attributes and behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@frontend/pages/admin/IntegrationsPage/cards/IdentityProviders/components/EndUserAuthSection/EndUserAuthSection.tsx`:
- Line 148: The anchor in EndUserAuthSection (EndUserAuthSection.tsx) currently
sets rel="noreferrer"; update the rel attribute to include noopener (e.g.,
rel="noreferrer noopener") on the same <a> element to ensure the opened page
cannot access window.opener, keeping the rest of the link attributes and
behavior unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 69a1495c-65d8-4549-b0d7-ff7a5429bb1d
📒 Files selected for processing (1)
frontend/pages/admin/IntegrationsPage/cards/IdentityProviders/components/EndUserAuthSection/EndUserAuthSection.tsx
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
dantecatalfamo
left a comment
There was a problem hiding this comment.
Big change, took a long time to review
Resolves #40164
Manually verified:

Adds a "Learn more" link to the End-user Authentication documentation on the
/settings/integrations/sso/end-userspage, making it easier for customers to reference docs while configuring SSO settings.EndUserAuthSection.tsx: Appended aLearn moreanchor (opens in new tab) after the description text in the end-user auth settings card.Summary by CodeRabbit