Partial cherry-pick of #42773: Add MAC address vital (Vitals.tsx + constants.tsx only)#42869
Closed
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Closed
Partial cherry-pick of #42773: Add MAC address vital (Vitals.tsx + constants.tsx only)#42869kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #42869 +/- ##
========================================
Coverage 66.82% 66.82%
========================================
Files 2544 2544
Lines 204231 204232 +1
Branches 9274 9159 -115
========================================
+ Hits 136474 136475 +1
Misses 55405 55405
Partials 12352 12352
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Make that 4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vitals.tsxandconstants.tsx"primary_mac"to theHOST_VITALS_DATAarray infrontend/utilities/constants.tsxfrontend/pages/hosts/details/cards/Vitals/Vitals.tsx, displayingprimary_macfrom the host API response usingDataSet+TooltipTruncatedTextHostDetailsPage.tsxformatting change from the original PRChanges
frontend/utilities/constants.tsx— Added"primary_mac"toHOST_VITALS_DATAfrontend/pages/hosts/details/cards/Vitals/Vitals.tsx— Added MAC address vital within the existing!isIosOrIpadosHost && !isAndroidHostconditional blockBuilt for Rachael Shaw by Kilo for Slack