Switch FMA manifest retrieval to use Cloudflare R2 bucket#43012
Switch FMA manifest retrieval to use Cloudflare R2 bucket#43012
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Switches the Fleet-maintained apps (FMA) manifest download base URL from GitHub raw content to the maintained-apps.fleetdm.com endpoint (Cloudflare R2-backed), and documents the new outbound dependency.
Changes:
- Updated the base URL used by maintained apps sync to
https://maintained-apps.fleetdm.com/manifests. - Added a changelog entry warning operators to allowlist the new manifests host.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| server/mdm/maintainedapps/sync.go | Points manifest retrieval at the new maintained-apps domain instead of GitHub raw content. |
| changes/42751-r2-fma | Documents the user-visible change and new outbound network requirement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| const fmaOutputsBase = "https://raw.githubusercontent.com/fleetdm/fleet/refs/heads/main/ee/maintained-apps/outputs" | ||
| const fmaOutputsBase = "https://maintained-apps.fleetdm.com/manifests" |
There was a problem hiding this comment.
fmaOutputsBase no longer matches the new path/name (/manifests). Renaming this constant to something like fmaManifestsBaseURL (and updating its usages) would make the intent clearer and avoid confusion during future maintenance.
There was a problem hiding this comment.
This is a minimal change on a Friday afternoon. Nope, not touching this.
| } | ||
|
|
||
| const fmaOutputsBase = "https://raw.githubusercontent.com/fleetdm/fleet/refs/heads/main/ee/maintained-apps/outputs" | ||
| const fmaOutputsBase = "https://maintained-apps.fleetdm.com/manifests" |
There was a problem hiding this comment.
This introduces a new hard-coded external dependency for production sync behavior. Consider making the base URL configurable (e.g., via server config/env with a sane default) so operators can quickly redirect/override in incident scenarios (DNS issues, regional blocks, temporary migration), rather than requiring a redeploy.
There was a problem hiding this comment.
This is already configurable.
| @@ -0,0 +1 @@ | |||
| * Switched Fleet-maintained apps serving location from GitHub to https://maintained-apps.fleetdm.com/manifests. If you limit outbound Fleet server traffic, make sure it can access the new FMA manifests location. | |||
There was a problem hiding this comment.
The changelog sentence references “FMA manifests location” without defining “FMA” in this entry. Consider expanding it once (e.g., “Fleet-maintained apps (FMA)”) to keep the entry self-contained for readers skimming release notes.
| * Switched Fleet-maintained apps serving location from GitHub to https://maintained-apps.fleetdm.com/manifests. If you limit outbound Fleet server traffic, make sure it can access the new FMA manifests location. | |
| * Switched Fleet-maintained apps (FMA) serving location from GitHub to https://maintained-apps.fleetdm.com/manifests. If you limit outbound Fleet server traffic, make sure it can access the new FMA manifests location. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43012 +/- ##
==========================================
+ Coverage 66.85% 66.86% +0.01%
==========================================
Files 2578 2578
Lines 206880 206880
Branches 9166 9166
==========================================
+ Hits 138301 138332 +31
+ Misses 56003 55979 -24
+ Partials 12576 12569 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #42751
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Testing