Skip to content

fix: edge case where zoomToOrigin unsets the fixed camera #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flekschas merged 1 commit into from
Dec 11, 2024
Merged

fix: edge case where zoomToOrigin unsets the fixed camera #203

flekschas merged 1 commit into from
Dec 11, 2024

Conversation

@flekschas
Copy link
Owner

@flekschas flekschas commented Dec 11, 2024

This PR fixes another edge case where zoomToOrigin was unsetting the camera fixed state.

Description

What was changed in this pull request?

zoomToLocation (and zoomToOrigin as a consequence) had accidentally unset the camera fixed state. Now they respect the cameraIsFixed setting

Checklist

  • Provided a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties")
  • CHANGELOG.md updated
  • Tests added or updated
  • Documentation in README.md added or updated
  • Example(s) added or updated
  • Screenshot, gif, or video attached for visual changes

@flekschas flekschas merged commit e2f0db8 into main Dec 11, 2024
2 checks passed
@flekschas flekschas deleted the flekschas/fix-camera-fixed-bug branch December 11, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flekschas