Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## 1.12.1

- Fix: prevent drawing points if all are filtered out ([#201](https://github.com/flekschas/regl-scatterplot/issues/201))
- Fix: destroy the encoding texture before recreating it
- Fix: reject `set()` calls if the instance was destroyed
- Fix: ensures unnecessary color and encoding texture updates are avoided
Expand Down
5 changes: 3 additions & 2 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2270,7 +2270,7 @@ const createScatterplot = (
const filteredSelectedPoints = [];

for (const pointIdx of pointIdxsArray) {
if (pointIdx < 0 || pointIdx >= numPoints) {
if (!Number.isFinite(pointIdx) || pointIdx < 0 || pointIdx >= numPoints) {
// Skip invalid filtered points
continue;
}
Expand Down Expand Up @@ -4322,7 +4322,8 @@ const createScatterplot = (
});
}

if (isPointsDrawn) {
const numPoints = getNormalNumPoints();
if (isPointsDrawn && numPoints > 0) {
drawPointBodies();
}

Expand Down
Loading