fix: Empty map/record defaults as {} and primitive short form preservation #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
1. Empty map/record defaults serialize as
[]instead of{}PHP's
json_encode([])produces"[]", but Avro specification requires empty map/record values to be"{}".Example:
2. Primitive types lose their short form
When parsing
"string"(short form), the library setserialize_type_attribute=true, causing it to serialize back as{"type": "string"}(long form).Example:
Solution
serialize_default_value()method that recursively converts PHP arrays tostdClassfor map/record types before JSON encodingserialize_type_attributefromtruetofalsewhen parsing primitive types in short form