Skip to content

Feature/v3/invest multi period #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
FBumann wants to merge 388 commits into
base: main
Choose a base branch
from
Draft

Feature/v3/invest multi period #452

FBumann wants to merge 388 commits into from

Conversation

@FBumann
Copy link
Member

@FBumann FBumann commented Oct 31, 2025 •
edited by coderabbitai bot
Loading

Description

Brief description of the changes in this PR.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring

Related Issues

Closes #(issue number)

Testing

  • I have tested my changes
  • Existing tests still pass

Checklist

  • My code follows the project style
  • I have updated documentation if needed
  • I have added tests for new functionality (if applicable)

Summary by CodeRabbit

  • New Features
    • Added timing-based investment parameters for flows, enabling users to define when investments can occur with forced timing constraints, lifetime and size bounds, and effects tied to investment decisions and decommissioning timing.

FBumann added 30 commits June 28, 2025 22:57
@FBumann
Change Transmission to have a "balanced" attribute. Change Tests acco…
15fd124 
…rdingly
@FBumann
Improve index validations
d0b231d
@FBumann
rename method in tests
4ebe6a5
@FBumann
Update DataConverter
6b56dac
@FBumann
Add DataFrame Support back
a7ec994
@FBumann
Add copy() to DataConverter
2a75ed3
@FBumann
Update fit_to_model_coords to take a list of coords
dae9f01
@FBumann
Make the DataConverter more universal by accepting a list of coords/dims
ba195ff
@FBumann
Update DataConverter for n-d arrays
605f034
@FBumann
Update DataConverter for n-d arrays
6560006
@FBumann
Add extra tests for 3-dims
78132ef
@FBumann
Add FLowSystemDimension Type
a53c116
@FBumann
Revert some logic about the fit_to_model coords
2cb551b
@FBumann
Adjust FLowSystem IO for scenarios
d7be766
@FBumann
BUGFIX: Raise Exception instead of logging
e60dd07
@FBumann
Change usage of TimeSeriesData
bd2f1b8
@FBumann
Adjust logic to handle non scalars
a7da9d2
@FBumann
Adjust logic to _resolve_dataarray_reference into separate method
b8f0e22
@FBumann
Update IO of FlowSystem
7123b6b
@FBumann
Improve get_coords()
fa5475d
@FBumann
Adjust FlowSystem init for correct IO
80cb161
@FBumann
Add scenario to sel and isel methods, and dont normalize scenario wei…
81ad3ba 
…ghts
@FBumann
Improve scenario_weights_handling
691a45e
@FBumann
Add warning for not scaled weights
3931ac5
@FBumann
Update test_scenarios.py
75a45e1
@FBumann
Improve util method
2882147
@FBumann
Add objective to solution dataset.
50491ff
@FBumann
Update handling of scenario_weights update tests
4f3a798
@FBumann
Ruff check. Fix type hints
314aef9
@FBumann
Fix type hints and improve None handling
0302947
FBumann added 28 commits November 1, 2025 14:05
@FBumann
Add proper handling of mandatory size for all cases: all, some, no pe…
e7fe67b 
…riod(s)
@FBumann
Bugfix
3c65db9
@FBumann
Bugfix
36fae3b
@FBumann
Rename fixed_lifetime to lifetime
2bddd5a
@FBumann
Fix type hints
52c1f8a
@FBumann
Small bugfixes
ae14baf
@FBumann
Small bugfixes
3db741d
@FBumann
Fix inherritance issues
24618d9
@FBumann
Fix missing availlable variable
f8ac1eb
@FBumann
Track lifetime
7f28d62
@FBumann
Temp
190ae49
@FBumann
Temp
e9b5287
@FBumann
Revert "Temp"
45c3fad 
This reverts commit e9b5287.
@FBumann
Revert "Temp"
e465a62 
This reverts commit 190ae49.
@FBumann
Add constraints for lifetime with warnings
3d2e52b
@FBumann
Improve warning massage
c1d501e
@FBumann
Improve warning message
85e7cc7
@FBumann
Fix
3a8bebd
@FBumann
Fix
e95f651
@FBumann
Fix
2bd61d5
@FBumann
Fix
75cb42a
@FBumann
Use ffill instead of bfill
603f54f
@FBumann
Revert "Use ffill instead of bfill"
37cebdd 
This reverts commit 603f54f.
@FBumann
Update
c9caf96
@FBumann
Fix
b50b0e5
@FBumann
Fix
1a9c5a7
@FBumann
Fix
c750fdc
@FBumann
Fix for scenarios
43561ed
@FBumann FBumann mentioned this pull request Nov 18, 2025
Closed
9 tasks
@FBumann
Copy link
Member Author

FBumann commented Nov 18, 2025

Closes #460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FBumann