Filter all exceptions when sendFullErrorException is false#4200
Closed
roumn wants to merge 1 commit intoflowable:mainfrom
Closed
Filter all exceptions when sendFullErrorException is false#4200roumn wants to merge 1 commit intoflowable:mainfrom
roumn wants to merge 1 commit intoflowable:mainfrom
Conversation
Contributor
Author
|
Does not make sense, will close PR. This would break too many things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, only handleBadMessageConversion and handleOtherException in BaseExceptionHandlerAdvice respected the sendFullErrorException flag. All other exception handlers (handleNotSupported, handleConflict, handleNotFound, handleForbidden, handleIllegalArgument, handleIllegalState, handleTaskAlreadyClaimed) always returned the full exception message in the response, regardless of the flag.
This change applies the same pattern consistently to all handlers: when sendFullErrorException is false, a UUID error identifier is generated and logged at WARN level, and only the error identifier is returned to the client — preventing internal error details from leaking in the REST API response.
The test class has been updated accordingly, using ${json-unit.regex} matchers to verify the error ID pattern in each handler's response.