[google_maps_flutter] Add onPoiTap callback to GoogleMap by AsimRoyChowdhury · Pull Request #10963 · flutter/packages

AsimRoyChowdhury · 2026-02-04T15:18:51Z

This PR adds support for detecting taps on the base map's Points of Interest.

Issue: Fixes flutter/flutter#60695

Changes:

platform_interface: Added PointOfInterest type, MapPoiTapEvent, and onPoiTap stream definition.
android: Implemented OnPoiClickListener in GoogleMapController and wired the event to the method channel.
ios: Implemented GMSMapViewDelegate POI tap handling and forwarded events to Dart.
app-facing package: Exposed onPoiTap in the GoogleMap widget and GoogleMapController.
example: Added a new "Place POI" example page to demonstrate the feature.

Fixes: N/A - This is a new feature.

Pre-Review Checklist

gemini-code-assist

Code Review

This pull request introduces the onPoiTap callback to the GoogleMap widget, allowing developers to handle user taps on points of interest on the map. The feature is implemented across the platform interface, Android, and iOS, with corresponding updates to the example application and tests. The changes involve adding new event types, updating platform-specific listeners, and exposing the new callback in the app-facing widget. My review includes suggestions for improving code clarity, test robustness, and fixing a critical dependency issue.

gemini-code-assist · 2026-02-04T15:23:33Z

packages/google_maps_flutter/google_maps_flutter_ios/pubspec.yaml

  flutter:
    sdk: flutter
-  google_maps_flutter_platform_interface: ^2.13.0
+  google_maps_flutter_platform_interface: ^2.14.0


The google_maps_flutter_platform_interface version should be ^2.15.0 to match the version in which onPoiTap support was added. The current version ^2.14.0 will cause dependency conflicts or build failures since this package uses types introduced in 2.15.0.

google_maps_flutter_platform_interface: ^2.15.0

packages/google_maps_flutter/google_maps_flutter/example/lib/place_poi.dart

gemini-code-assist · 2026-02-04T15:23:34Z

packages/google_maps_flutter/google_maps_flutter/lib/google_maps_flutter.dart

 import 'package:google_maps_flutter_android/google_maps_flutter_android.dart';
 import 'package:google_maps_flutter_platform_interface/google_maps_flutter_platform_interface.dart';

+import 'package:google_maps_flutter_platform_interface/google_maps_flutter_platform_interface.dart';


This import is redundant as google_maps_flutter_platform_interface is already imported on line 13. Please remove this duplicate line to improve code cleanliness.

gemini-code-assist · 2026-02-04T15:23:34Z

...flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java

+    Log.e("POI_TEST", "Native POI Click Detected: " + poi.name);
+    Log.e("POI_TEST", "Native Tap! Sending to Channel ID: " + id);


Using Log.e for debugging messages is not recommended as it implies an error has occurred and can clutter error logs. For debugging purposes, it's better to use Log.d or Log.v. These temporary debug logs should be removed before merging.

gemini-code-assist · 2026-02-04T15:23:34Z

...ter_android/android/src/test/java/io/flutter/plugins/googlemaps/GoogleMapControllerTest.java

+  public void onPoiClick_SendsMethodCall() {
+    PointOfInterest poi = new PointOfInterest(new LatLng(1.0, 2.0), "placeId", "name");
+
+    // controller is the instance of GoogleMapController in your test file
+    controller.onPoiClick(poi);
+
+    // Verify the messenger sent the message to the correct channel
+    verify(binaryMessenger).send(
+        eq("plugins.flutter.io/google_maps_0"), 
+        any(ByteBuffer.class), 
+        any(BinaryMessenger.BinaryReply.class));
+  }


This test only verifies that a message is sent on the binary messenger, but it doesn't check the content of the message. A more robust test would be to use a mock MapsCallbackApi and verify that onPoiTap is called with the correct data. This ensures that the data is correctly constructed and passed to the Pigeon API.

Here's an example of how you could improve it:

@Test public void onPoiClick_sendsCorrectData() { // Assuming 'controller' and 'flutterApi' are set up as in other tests. PointOfInterest poi = new PointOfInterest(new LatLng(1.0, 2.0), "placeId", "name"); controller.onPoiClick(poi); ArgumentCaptor<Messages.PlatformPointOfInterest> poiCaptor = ArgumentCaptor.forClass(Messages.PlatformPointOfInterest.class); verify(flutterApi).onPoiTap(poiCaptor.capture(), any(Messages.VoidResult.class)); Messages.PlatformPointOfInterest capturedPoi = poiCaptor.getValue(); assertEquals("name", capturedPoi.getName()); assertEquals("placeId", capturedPoi.getPlaceId()); assertEquals(1.0, capturedPoi.getPosition().getLatitude(), 1e-6); assertEquals(2.0, capturedPoi.getPosition().getLongitude(), 1e-6); }

gemini-code-assist · 2026-02-04T15:23:34Z

...ages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/callbacks.dart

+/// Callback method for when a [PointOfInterest] is tapped.
+typedef POIClickCallback = void Function(PointOfInterest poi);


The POIClickCallback typedef appears to be unused in the codebase. To maintain code cleanliness, please remove it.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

stuartmorgan-g

Thanks for the contribution!

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.

This needs to follow our documented process for changing federated plugins, so that CI works.

Please also be sure to review the feedback on the previous PR, especially this comment, and update accordingly. Even if this PR doesn't include web support (although it would be preferable if it did, especially since there is a previous PR to draw on), it does need to be designed in such a way as to not cause this problem for web later.

stuartmorgan-g · 2026-02-04T16:40:28Z

packages/google_maps_flutter/google_maps_flutter/test/google_map_test.dart

+      ),
+    );
+
+    // 🔥 IMPORTANT: Wait for the map initialization (onMapCreated) to complete


Please follow our standard commenting style. Sentences should be properly punctuated, and we don't use emoji in comments.

stuartmorgan-g · 2026-02-04T16:41:50Z

packages/google_maps_flutter/google_maps_flutter/test/google_map_test.dart

+    );
+
+    // 🔥 IMPORTANT: Wait for the map initialization (onMapCreated) to complete
+    await tester.pumpAndSettle();


pumpAndSettle is for waiting for rendering to complete, not for arbitrary specific tasks. The way to wait for onMapCreated to complete is to have a future that completes when onMapCreated is called, and then wait for that. It is important that tests not be flaky because they are using delays as a proxy for waiting for specific conditions.

Please review the package again. I have done the following works:

Revamped the code as per the review of @stuartmorgan-g and @gemini_code_assist

Added Support for flutter web for onPoiTap Callback

Added Integration test for onPoiTap

Updated Version for the google_maps_flutter_web package

Thank you for addressing the feedback regarding the pumpAndSettle usage. The updated test now correctly waits for onMapCreated to complete using a Completer, which is a much more robust approach.

…orm_interface

…pCreated

…ssage content being passed rather than the detecting if a binary message is being sent

… web

…imRoyChowdhury/packages into feature/google-maps-poi-click

…kage

…ckage only

stuartmorgan-g

I've left some initial feedback.

This is not the first time I've had to point out that previous feedback has not been addressed. Please ensure that you either address feedback, or ask for clarification if necessary, before requesting review again.

stuartmorgan-g · 2026-02-12T15:13:00Z

packages/google_maps_flutter/google_maps_flutter_android/lib/src/messages.g.dart.orig

Generated files should never be patched or reconciled in merges, they should be regenerated from the source. These files should absolutely not be part of the PR, but the fact that they existed locally suggests that you haven't ensured up-to-date generated output.

stuartmorgan-g · 2026-02-12T15:13:49Z

packages/google_maps_flutter/google_maps_flutter/lib/src/google_map.dart

  final Set<ClusterManager> clusterManagers;

+  /// Callback for Point of Interests tap
+  final ArgumentCallback<PointOfInterest>? onPoiTap;


This needs to be grouped with, and following the same comment style as, all the other callbacks.

stuartmorgan-g · 2026-02-12T15:14:23Z

...lutter_ios/ios/google_maps_flutter_ios/Sources/google_maps_flutter_ios/GoogleMapController.m

This change should have corresponding native unit tests.

stuartmorgan-g · 2026-02-12T15:15:15Z

...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart


+  /// A [PointOfInterest] has been tapped.
+  Stream<MapPoiTapEvent> onPoiTap({required int mapId}) {
+    throw UnimplementedError('onPoiTap() has not been implemented.');


This should return an empty stream, not throw, to avoid breaking existing implementations.

stuartmorgan-g · 2026-02-12T15:25:11Z

packages/google_maps_flutter/google_maps_flutter/lib/src/google_map.dart

  final Set<ClusterManager> clusterManagers;

+  /// Callback for Point of Interests tap
+  final ArgumentCallback<PointOfInterest>? onPoiTap;


My previous comment has not been addressed. This is still returning an inflated POI rather than an ID.

gemini-code-assist

Code Review

This pull request introduces onPoiTap support for the GoogleMap widget, enabling tap detection on Points of Interest across Android, iOS, and web. The changes are well-implemented, touching the platform interface, all three platform implementations, and adding a new example page with tests. My review includes a minor code simplification suggestion and points out several patch-related artifact files that should be removed to maintain repository cleanliness. Overall, this is a great feature addition.

gemini-code-assist · 2026-02-12T15:42:52Z

...ages/google_maps_flutter/google_maps_flutter_android/example/lib/example_google_map.dart.rej

@@ -0,0 +1,11 @@
+--- packages/google_maps_flutter/google_maps_flutter_android/example/lib/example_google_map.dart


This file appears to be a patch reject file (.rej) that was likely added by accident. Please remove it from the pull request to keep the repository clean.

gemini-code-assist · 2026-02-12T15:42:52Z

packages/google_maps_flutter/google_maps_flutter_android/lib/src/messages.g.dart.rej

@@ -0,0 +1,1574 @@
+--- packages/google_maps_flutter/google_maps_flutter_android/lib/src/messages.g.dart


This .rej file seems to be a patch artifact and should not be included in the pull request. Please remove it.

gemini-code-assist · 2026-02-12T15:42:52Z

...aps_flutter_ios/include/google_maps_flutter_ios/google_maps_flutter_pigeon_messages.g.h.orig

@@ -0,0 +1,901 @@
+// Copyright 2013 The Flutter Authors


This .orig file seems to be an artifact from a merge or patch tool. It should be removed from the pull request.

gemini-code-assist · 2026-02-12T15:42:52Z

...maps_flutter_ios/include/google_maps_flutter_ios/google_maps_flutter_pigeon_messages.g.h.rej

@@ -0,0 +1,807 @@
+--- packages/google_maps_flutter/google_maps_flutter_ios/ios/google_maps_flutter_ios/Sources/google_maps_flutter_ios/include/google_maps_flutter_ios/google_maps_flutter_pigeon_messages.g.h


This patch reject file (.rej) appears to be an unintended artifact. Please remove it from the commit.

gemini-code-assist · 2026-02-12T15:42:52Z

packages/google_maps_flutter/google_maps_flutter_ios/lib/src/messages.g.dart.rej

@@ -0,0 +1,1496 @@
+--- packages/google_maps_flutter/google_maps_flutter_ios/lib/src/messages.g.dart


This .rej file is likely a patch artifact and should be removed from the pull request.

gemini-code-assist · 2026-02-12T15:42:52Z

packages/google_maps_flutter/google_maps_flutter/lib/src/google_map.dart

+    if (widget.onPoiTap != null) {
+      widget.onPoiTap!(poi);
+    }


For conciseness, you can use the null-aware ?.call() operator here.

widget.onPoiTap?.call(poi);

@stuartmorgan-g can you please see the code changes again. I have removed the name param from the onPoiTap. As you said that it sent inflated POI values in the web version. In the web version the name is not there in the native implementation which is why the inflated values were returned that's why I have removed the name param from all platform implementations and kept only the placeId and position.

As the unimplemented error was thrown which would have resulted in a breaking change so I have changed it to return an empty string instead of throwing.

I also applied the make-deps-path-based tooling but it was resulting in blank dependency overrides so I had to add the dependency overrides manually. Please help me in understanding this if I am using the tool incorrectly.

Above all thank you for your constant valuable feedback on the errors I was doing continuously, it would be great if you explain more about the errors if those happen again, and I have read the documentation regarding the federated plugin change and did all what I understood, please guide me if I have left something unaddressed.

I have removed the name param from the onPoiTap.

It appears that you have removed the name from the PointOfInterest class, which would make it impossible to have the method discussed in the linked comment thread that would query for POI information.

The issue is not that POI doesn't have a name on web, it's that the tap event callback doesn't return a POI on web. That can't be fixed by removing information from POI itself. It needs to be solved by having the tap handler receive something that is not the POI class.

…s, formatting and removed name from PointOfInterest Model

… resolved syntax error

AsimRoyChowdhury added 4 commits February 4, 2026 19:14

[google_maps_flutter] Added Point of Interest Tapping

11cc8c9

[google_maps_flutter] Added example for Point of Interest Tapping

18d0e19

[google_maps_flutter] Added tests for onPoiTap Callback

fa00c6a

[google_maps_flutter] Updated Changelogs and Pubspec.yml files

ca71a07

AsimRoyChowdhury requested review from LongCatIsLooong, reidbaker, stuartmorgan-g and vashworth as code owners February 4, 2026 15:18

github-actions bot added p: google_maps_flutter platform-android platform-ios labels Feb 4, 2026

Merge branch 'main' into feature/google-maps-poi-click

a28a4db

gemini-code-assist bot reviewed Feb 4, 2026

View reviewed changes

Apply suggestion from @gemini-code-assist[bot]

2aa24ed

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

stuartmorgan-g requested changes Feb 4, 2026

View reviewed changes

stuartmorgan-g changed the title ~~feat: [google_maps_flutter] Add onPoiTap callback to GoogleMap~~ [google_maps_flutter] Add onPoiTap callback to GoogleMap Feb 4, 2026

stuartmorgan-g reviewed Feb 4, 2026

View reviewed changes

AsimRoyChowdhury added 9 commits February 5, 2026 20:22

[google_maps_flutter] corrected version for google_maps_flutter_platf…

3c8b5b6

…orm_interface

[google_maps_flutter] removed redundant import

d54f1b3

[google_maps_flutter] changed tester.pumpAndSettle() to await on onMa…

904a092

…pCreated

[google_maps_flutter] removed unnecessary logging to console

7b8f809

[google_maps_flutter] changed the test code to test for the actual me…

e8d0682

…ssage content being passed rather than the detecting if a binary message is being sent

[google_maps_flutter] removed the unnecessary POIClickCallback typedef

752925f

[google_maps_flutter] added support for onPoiTap for flutter web

69ecb49

[google_maps_flutter] created tests for onPoiTap Callback for flutter…

8e522fa

… web

Merge branch 'feature/google-maps-poi-click' of https://github.com/As…

ae2a1ea

…imRoyChowdhury/packages into feature/google-maps-poi-click

AsimRoyChowdhury requested a review from mdebbar as a code owner February 5, 2026 18:37

github-actions bot added the platform-web label Feb 5, 2026

[google_maps_flutter] updated versions for google map flutter web pac…

7552d23

…kage

github-actions bot added the p: video_player label Feb 7, 2026

[google_maps_flutter] added onPoiTap changes to platform interface pa…

72f43f3

…ckage only

github-actions bot removed platform-web platform-android platform-ios platform-macos p: video_player labels Feb 7, 2026

[google_maps_flutter] removed unncessary files

3079afc

AsimRoyChowdhury force-pushed the feature/google-maps-poi-click branch from 4512a35 to 3079afc Compare February 7, 2026 09:17

AsimRoyChowdhury requested a review from stuartmorgan-g February 7, 2026 15:42

stuartmorgan-g marked this pull request as draft February 7, 2026 22:25

[google_maps_flutter] implemented onPoiTap callback for all packages

9b17699

github-actions bot added platform-android platform-ios platform-web labels Feb 8, 2026

[google_maps_flutter] updated changelog.md for web package

7596469

stuartmorgan-g requested changes Feb 12, 2026

View reviewed changes

stuartmorgan-g marked this pull request as ready for review February 12, 2026 15:29

gemini-code-assist bot reviewed Feb 12, 2026

View reviewed changes

AsimRoyChowdhury added 11 commits February 13, 2026 00:48

[google_maps_flutter] Fix federated PR structure: overrides, artifact…

9cc391e

…s, formatting and removed name from PointOfInterest Model

[google_maps_flutter] updated formatting errors

28b709b

[google_maps_flutter] updated pubspecs to use dart sdk 3.8.0

2589982

[google_maps_flutter] updated web version to 0.7.0

5acc132

[google_maps_flutter] removed name from onPoiClick tests

9d9139c

[google_maps_flutter] updated format

b57aba0

[google_maps_flutter] added the name field

679b64f

[google_maps_flutter] downgraded sdk version in examples

f7cd0a2

[google_maps_flutter] updated web version to use 0.5.15

f1480dd

[google_maps_flutter] updated pubspecs for dependency overrides

89450b3

[google_maps_flutter] updated google_maps_flutter example pubspec and…

d0f16d6

… resolved syntax error

		Log.e("POI_TEST", "Native POI Click Detected: " + poi.name);
		Log.e("POI_TEST", "Native Tap! Sending to Channel ID: " + id);

		/// Callback method for when a [PointOfInterest] is tapped.
		typedef POIClickCallback = void Function(PointOfInterest poi);

		@@ -0,0 +1,11 @@
		--- packages/google_maps_flutter/google_maps_flutter_android/example/lib/example_google_map.dart

		@@ -0,0 +1,1574 @@
		--- packages/google_maps_flutter/google_maps_flutter_android/lib/src/messages.g.dart

		@@ -0,0 +1,807 @@
		--- packages/google_maps_flutter/google_maps_flutter_ios/ios/google_maps_flutter_ios/Sources/google_maps_flutter_ios/include/google_maps_flutter_ios/google_maps_flutter_pigeon_messages.g.h

		@@ -0,0 +1,1496 @@
		--- packages/google_maps_flutter/google_maps_flutter_ios/lib/src/messages.g.dart

Conversation

AsimRoyChowdhury commented Feb 4, 2026 • edited by stuartmorgan-g Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Pre-Review Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

AsimRoyChowdhury commented Feb 4, 2026 •

edited by stuartmorgan-g

Loading