Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Version-change-exempt per documented repo policy on dropping SDK versions. |
|
test-exempt: configuration change |
There was a problem hiding this comment.
Code Review
This pull request updates the repository for the Flutter 3.41 stable release. The changes primarily involve bumping the minimum supported SDK versions to Flutter 3.35 and Dart 3.9 across numerous packages, updating CHANGELOG.md files, and adjusting CI configurations.
My review found one minor issue with a redundant changelog entry. Otherwise, the changes appear to be consistent and correct for a repository-wide version update.
| @@ -1,3 +1,7 @@ | |||
| ## NEXT | |||
|
|
|||
| * Updates minimum supported SDK version to Flutter 3.35/Dart 3.9. | |||
|
One of the web tests is failing with some platform view errors. cc @harryterkelsen |
robert-ancell
left a comment
There was a problem hiding this comment.
Checked all Linux packages, no issues there.
Updates the repo for the 3.41 stable release.
This does everything in https://github.com/flutter/flutter/blob/master/docs/ecosystem/release/Updating-Packages-repo-for-a-stable-release.md except for:
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3