[google_maps_flutter] Use super parameters in more places in examples#11517
[google_maps_flutter] Use super parameters in more places in examples#11517srawlins wants to merge 3 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates numerous example files across the Google Maps Flutter packages to utilize the super.key constructor parameter shorthand. A review comment suggests moving the super.key parameter to the beginning of the parameter list in advanced_marker_icons.dart to maintain consistency with Flutter conventions and other constructors in the repository.
Changes to the Dart analyzer will catch more situations where super-parameters should be used, for the
use_super_parameterslint rule. We need to clean up this example code before it can land.Work towards dart-lang/sdk#58729
Pre-Review Checklist
[shared_preferences]///).