Skip to content

[google_maps_flutter] Use super parameters in more places in examples#11517

Open
srawlins wants to merge 3 commits intoflutter:mainfrom
srawlins:super
Open

[google_maps_flutter] Use super parameters in more places in examples#11517
srawlins wants to merge 3 commits intoflutter:mainfrom
srawlins:super

Conversation

@srawlins
Copy link
Copy Markdown
Contributor

Changes to the Dart analyzer will catch more situations where super-parameters should be used, for the use_super_parameters lint rule. We need to clean up this example code before it can land.

Work towards dart-lang/sdk#58729

Pre-Review Checklist

@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates numerous example files across the Google Maps Flutter packages to utilize the super.key constructor parameter shorthand. A review comment suggests moving the super.key parameter to the beginning of the parameter list in advanced_marker_icons.dart to maintain consistency with Flutter conventions and other constructors in the repository.

@srawlins srawlins added the CICD Run CI/CD label Apr 16, 2026
@github-actions github-actions bot removed the CICD Run CI/CD label Apr 16, 2026
@srawlins srawlins added the CICD Run CI/CD label Apr 16, 2026
@github-actions github-actions bot removed the CICD Run CI/CD label Apr 16, 2026
@srawlins srawlins added the CICD Run CI/CD label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant