[video_player] Issue 166411 preferred audio language support for player creation#12152
Open
Zubii12 wants to merge 5 commits into
Open
[video_player] Issue 166411 preferred audio language support for player creation#12152Zubii12 wants to merge 5 commits into
Zubii12 wants to merge 5 commits into
Conversation
2afe303 to
b0a4aa6
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for configuring a preferred audio language during player creation via VideoPlayerOptions.preferredAudioLanguage across the video_player federated packages. The changes update the platform interface, forward the option during player initialization, and implement native track selection for Android (ExoPlayer) and iOS/macOS (AVFoundation). Unit tests and changelogs are updated accordingly. There are no review comments, so no additional feedback is provided.
b827a92 to
ce1bb95
Compare
…orm API and players
ce1bb95 to
0db81a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds preferredAudioLanguage to platform interface options and forwards it during player creation
Fixes flutter/flutter#166411
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2