Skip to content

[material_ui] Copies a11y_assessments - #12686

Open
chunhtai wants to merge 2 commits into
flutter:mainfrom
chunhtai:close_a11y_assessment
Open

[material_ui] Copies a11y_assessments#12686
chunhtai wants to merge 2 commits into
flutter:mainfrom
chunhtai:close_a11y_assessment

Conversation

@chunhtai

@chunhtai chunhtai commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

as title.

Move the app in material give use benefit that we can both fix accessibility issue and verify the fix on the app faster without waiting for a release cycle

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Flutter project, a11y_assessments, designed for accessibility testing across multiple platforms including Android, iOS, Linux, macOS, Web, and Windows. It implements a wide range of widget use cases to assess accessibility compliance, along with corresponding tests. Feedback on the changes highlights a potential compilation issue in utils.cpp due to the use of a non-standard macro UNICODE_STRING_MAX_CHARS, and identifies several unused variables in action_chip.dart, card.dart, and navigation_drawer.dart that should be removed.

Comment thread packages/material_ui/a11y_assessments/windows/runner/utils.cpp
Comment thread packages/material_ui/a11y_assessments/lib/use_cases/card.dart
Comment thread packages/material_ui/a11y_assessments/lib/use_cases/navigation_drawer.dart Outdated
@chunhtai chunhtai added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 31, 2026
@chunhtai

Copy link
Copy Markdown
Contributor Author

reason for override: this is a sample app that won't be include in the release.

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just have a question, I saw the original app in flutter/flutter also have a GEMINI.md file, is it for agent learning? Just curious whether we also want that in material_ui.

@chunhtai

Copy link
Copy Markdown
Contributor Author

I saw the original app in flutter/flutter also have a GEMINI.md file, is it for agent learning? Just curious whether we also want that in material_ui.

I have no idea how it works, I think that is for gemini code assist, and I am not sure if it still working because the tech change fast. I will defer that to your team, but for now, I removed that file because packages repro doesn't have the same convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: material_ui platform-android platform-ios platform-linux platform-macos platform-web platform-windows triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants