[vector_graphics_compiler] Fix deprecation issues in tests - #12700
Merged
auto-submit[bot] merged 1 commit intoAug 31, 2026
Conversation
Contributor
Author
|
This doesn't need a pending changelog file since it only affects a test |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates matrix_test.dart to use scaledByDouble and translateByDouble instead of scaled and translate on Matrix4, and corrects the spelling of epsillon to epsilon. Feedback suggests using scientific notation 1e-7 instead of .0000001 for the epsilon constant to improve readability and follow Dart conventions.
|
|
||
| test('transformRect', () { | ||
| const epsillon = .0000001; | ||
| const epsilon = .0000001; |
Contributor
There was a problem hiding this comment.
In Dart, double literals should not start with a leading decimal point. It is cleaner and more idiomatic to use a leading zero (e.g., '0.0000001') or scientific notation (e.g., '1e-7'), which also improves readability by avoiding the need to manually count leading zeros.
Suggested change
| const epsilon = .0000001; | |
| const epsilon = 1e-7; |
stuartmorgan-g
requested review from
jtmcdole
and removed request for
stuartmorgan-g
August 31, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#178120
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2