Skip to content

[vector_graphics_compiler] Fix deprecation issues in tests - #12700

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
ValentinVignal:vector_graphics_compiler/Fix-deprecation-issues-in-tests
Aug 31, 2026
Merged

[vector_graphics_compiler] Fix deprecation issues in tests#12700
auto-submit[bot] merged 1 commit into
flutter:mainfrom
ValentinVignal:vector_graphics_compiler/Fix-deprecation-issues-in-tests

Conversation

@ValentinVignal

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#178120

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 31, 2026
@github-actions github-actions Bot added p: vector_graphics triage-engine Should be looked at in engine triage labels Aug 31, 2026
@ValentinVignal

Copy link
Copy Markdown
Contributor Author

This doesn't need a pending changelog file since it only affects a test

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates matrix_test.dart to use scaledByDouble and translateByDouble instead of scaled and translate on Matrix4, and corrects the spelling of epsillon to epsilon. Feedback suggests using scientific notation 1e-7 instead of .0000001 for the epsilon constant to improve readability and follow Dart conventions.


test('transformRect', () {
const epsillon = .0000001;
const epsilon = .0000001;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Dart, double literals should not start with a leading decimal point. It is cleaner and more idiomatic to use a leading zero (e.g., '0.0000001') or scientific notation (e.g., '1e-7'), which also improves readability by avoiding the need to manually count leading zeros.

Suggested change
const epsilon = .0000001;
const epsilon = 1e-7;

@stuartmorgan-g
stuartmorgan-g requested review from jtmcdole and removed request for stuartmorgan-g August 31, 2026 14:52
@gaaclarke
gaaclarke requested a review from andywolff August 31, 2026 20:26

@andywolff andywolff left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup

@andywolff andywolff added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2026
@auto-submit
auto-submit Bot merged commit c776615 into flutter:main Aug 31, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: vector_graphics triage-engine Should be looked at in engine triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants