[material_ui] Migrate M3 DatePicker template to use new gen_defaults - #12914
Open
QuncCccccc wants to merge 1 commit into
Open
QuncCccccc wants to merge 1 commit into
QuncCccccc wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the Material 3 DatePicker defaults to the new token-based generator template (DatePickerTemplateM3), replacing the old template and moving the generated defaults into a separate part file. The generator script and tests have been updated to enable and verify this generation. Review feedback suggests replacing a hardcoded opacity value of 0.60 in the template with a token to improve consistency.
| Color? get backgroundColor => ${color(TokenDatePickerModal.containerColor)}; | ||
|
|
||
| @override | ||
| Color? get subHeaderForegroundColor => ${color(TokenDatePickerModal.weekdaysLabelTextColor)}.withOpacity(0.60); |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work toward flutter/flutter#187899.
Fixes flutter/flutter#188410.
Migrates the M3 DatePicker defaults template to the new packages/material_ui/tool/gen_defaults generator.
Pre-Review Checklist
[shared_preferences]///).