Skip to content

[material_ui] Migrate M3 DatePicker template to use new gen_defaults - #12914

Open
QuncCccccc wants to merge 1 commit into
flutter:mainfrom
QuncCccccc:date_picker_m3_defaults_migration
Open

QuncCccccc wants to merge 1 commit into
flutter:mainfrom
QuncCccccc:date_picker_m3_defaults_migration

Conversation

@QuncCccccc

Copy link
Copy Markdown
Contributor

Work toward flutter/flutter#187899.
Fixes flutter/flutter#188410.

Migrates the M3 DatePicker defaults template to the new packages/material_ui/tool/gen_defaults generator.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 18, 2026
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 18, 2026
@QuncCccccc QuncCccccc added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Sep 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the Material 3 DatePicker defaults to the new token-based generator template (DatePickerTemplateM3), replacing the old template and moving the generated defaults into a separate part file. The generator script and tests have been updated to enable and verify this generation. Review feedback suggests replacing a hardcoded opacity value of 0.60 in the template with a token to improve consistency.

Color? get backgroundColor => ${color(TokenDatePickerModal.containerColor)};

@override
Color? get subHeaderForegroundColor => ${color(TokenDatePickerModal.weekdaysLabelTextColor)}.withOpacity(0.60);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The opacity value 0.60 is hardcoded. Other opacity values in this template are derived from tokens (e.g., TokenState.disabledStateLayerOpacity). To improve maintainability and consistency, please consider using a token for this opacity value as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

date_picker_template.dart

1 participant