oci: preserve dir mode when extracting tar layers#1151
Open
frazew wants to merge 1 commit intofluxcd:mainfrom
Open
oci: preserve dir mode when extracting tar layers#1151frazew wants to merge 1 commit intofluxcd:mainfrom
frazew wants to merge 1 commit intofluxcd:mainfrom
Conversation
OCI push/pull/diff is currently not "round-trip" safe, because the tar extraction function hardcodes 0o750 for directories Signed-off-by: François HORTA <fhorta@scaleway.com>
6f83d33 to
e6725e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCI push/pull/diff is currently not "round-trip" safe, because the tar extraction function hardcodes
0o750for directoriesThis:
Outputs the following, which feels very weird:
This was noticed while debugging why
flux diffalways returned a diff, even for seemingly identical file trees. Maybe there's a specific reason for doing that, but I couldn't find one while looking around the git / Github PR history!There's (in my opinion) another issue with file modes not being fixed when creating the tar layers, but that would need to be in another PR and might need discussion because it might be a breaking change? (i.e. I think the code here should also rewrite
header.Modeto0o750/0o640so that umask differences between machines don't impact the final artifact)