[release/v1.8.x] Improve error message for encrypted SSH keys without password#2018
Merged
matheuscscp merged 1 commit intorelease/v1.8.xfrom Apr 1, 2026
Merged
Conversation
Detect encrypted SSH identity keys early in getAuthOpts() by parsing with ssh.ParseRawPrivateKey and checking for PassphraseMissingError. When detected, return a clear error pointing the user to add the 'password' field to their Secret instead of the misleading "SSH agent requested but SSH_AUTH_SOCK not-specified" message. Fixes #802 Signed-off-by: Ogulcan Aydogan <ogulcanaydogan@hotmail.com> (cherry picked from commit 790be38)
matheuscscp
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport to
release/v1.8.x, triggered by a label in #2013.