Don't require std::locale in chrono.h when FMT_USE_LOCALE is 0 - #4921
Open
nebkat wants to merge 1 commit into
Open
Don't require std::locale in chrono.h when FMT_USE_LOCALE is 0#4921nebkat wants to merge 1 commit into
std::locale in chrono.h when FMT_USE_LOCALE is 0#4921nebkat wants to merge 1 commit into
Conversation
vitaut
requested changes
Sep 6, 2026
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. Reducing locale use is a good idea but we shouldn't introduce too much conditional compilation. locale_ref might help with that.
tm_writer takes a locale_ref, which is already empty without locale support, instead of a std::locale reference, and the facet calls are confined to three shims. get_locale, which existed only to materialize and own a std::locale, is no longer needed. Output is unchanged; an -Os test program loses all 16 of its std::locale and time_put symbols, and the default build gets slightly smaller as well.
nebkat
force-pushed
the
chrono-no-locale
branch
from
September 7, 2026 02:41
f7aca46 to
a17f354
Compare
Contributor
Author
|
Reworked along those lines. One gap if you want it covered: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tm_writertakes alocale_ref, which is already empty without locale support, so the facet calls compile away andget_localeis no longer needed. Output is unchanged; an -Os test program loses all 16 of itsstd::localeandtime_putsymbols and ~4.3kB.