Fix argument count in dynamic stores with named arguments - #4933
Open
IfkumRfnl wants to merge 1 commit into
Open
Fix argument count in dynamic stores with named arguments#4933IfkumRfnl wants to merge 1 commit into
IfkumRfnl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code counted formatting arguments incorrectly when named arguments were present. It took the internal metadata slot as a formatting argument. Change made the math correct with
i.e. subtracting 1 from the arguments vector count when named arguments are present which makes the counting correct. The corrected count is also used when constructing
basic_format_args. Also regression tests were added.