Fix debug string formatting for range formatters - #4936
Open
cuishuang wants to merge 1 commit into
Open
Conversation
Signed-off-by: cuishuang <imcusg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
range_format::debug_stringmanually added quotes around the result of the underlying string formatter. This bypassed debug string escaping and caused width specifications to exclude the quotes.For example, newline, quote, and backslash characters were emitted without the expected escaping, and
{:8}could produce a result wider than eight columns.Parse the underlying formatter first, enable its debug format for
range_format::debug_string, and delegate formatting directly to it. This ensures that escaping, alignment, and width are handled consistently by the standard string formatter.